From: Victor Nogueira <victor@mojatatu.com>
To: Zhengchao Shao <shaozhengchao@huawei.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
shuah@kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, weiyongjun1@huawei.com,
yuehaibing@huawei.com
Subject: Re: [PATCH net-next,v3 3/9] selftests/tc-testings: add selftests for bpf filter
Date: Thu, 15 Sep 2022 13:00:20 -0300 [thread overview]
Message-ID: <7c5d6f5f-9fc9-a184-1412-182106bb7a77@mojatatu.com> (raw)
In-Reply-To: <20220915063038.20010-4-shaozhengchao@huawei.com>
On 15/09/2022 03:30, Zhengchao Shao wrote:
> Test 23c3: Add cBPF filter with valid bytecode
> Test 1563: Add cBPF filter with invalid bytecode
> Test 2334: Add eBPF filter with valid object-file
> Test 2373: Add eBPF filter with invalid object-file
> Test 4423: Replace cBPF bytecode
> Test 5122: Delete cBPF filter
> Test e0a9: List cBPF filters
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
> ---
> .../tc-testing/tc-tests/filters/bpf.json | 171 ++++++++++++++++++
> 1 file changed, 171 insertions(+)
> create mode 100644 tools/testing/selftests/tc-testing/tc-tests/filters/bpf.json
>
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/bpf.json b/tools/testing/selftests/tc-testing/tc-tests/filters/bpf.json
> new file mode 100644
> index 000000000000..4c8e1fd8faab
> --- /dev/null
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/bpf.json
> @@ -0,0 +1,171 @@
> +[
> + {
> + "id": "23c3",
> + "name": "Add cBPF filter with valid bytecode",
> + "category": [
> + "filter",
> + "bpf-filter"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$TC qdisc add dev $DEV1 ingress"
> + ],
> + "cmdUnderTest": "$TC filter add dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf bytecode '4,40 0 0 12,21 0 1 2048,6 0 0 262144,6 0 0 0'",
> + "expExitCode": "0",
> + "verifyCmd": "$TC filter get dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf",
> + "matchPattern": "filter parent ffff: protocol ip pref 100 bpf chain [0-9]+ handle 0x1.*bytecode '4,40 0 0 12,21 0 1 2048,6 0 0 262144,6 0 0 0'",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DEV1 ingress"
> + ]
> + },
> + {
> + "id": "1563",
> + "name": "Add cBPF filter with invalid bytecode",
> + "category": [
> + "filter",
> + "bpf-filter"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$TC qdisc add dev $DEV1 ingress"
> + ],
Sorry for the nit-picking, you are still using tabs in some places.
Like in the line above.
> + "cmdUnderTest": "$TC filter add dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf bytecode '4,40 0 0 12,31 0 1 2048,6 0 0 262144,6 0 0 0'",
> + "expExitCode": "2",
> + "verifyCmd": "$TC filter get dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf",
> + "matchPattern": "filter parent ffff: protocol ip pref 100 bpf chain [0-9]+ handle 0x1.*bytecode '4,40 0 0 12,21 0 1 2048,6 0 0 262144,6 0 0 0'",
> + "matchCount": "0",
> + "teardown": [
> + "$TC qdisc del dev $DEV1 ingress"
> + ]
> + },
> + {
> + "id": "2334",
> + "name": "Add eBPF filter with valid object-file",
> + "category": [
> + "filter",
> + "bpf-filter"
> + ],
> + "plugins": {
> + "requires": "buildebpfPlugin"
> + },
> + "setup": [
> + "$TC qdisc add dev $DEV1 ingress"
> + ],
> + "cmdUnderTest": "$TC filter add dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf object-file $EBPFDIR/action.o section action-ok",
> + "expExitCode": "0",
> + "verifyCmd": "$TC filter get dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf",
> + "matchPattern": "filter parent ffff: protocol ip pref 100 bpf chain [0-9]+ handle 0x1 action.o:\\[action-ok\\].*tag [0-9a-f]{16}( jited)?",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DEV1 ingress"
> + ]
> + },
> + {
> + "id": "2373",
> + "name": "Add eBPF filter with invalid object-file",
> + "category": [
> + "filter",
> + "bpf-filter"
> + ],
> + "plugins": {
> + "requires": "buildebpfPlugin"
> + },
> + "setup": [
> + "$TC qdisc add dev $DEV1 ingress"
> + ],
> + "cmdUnderTest": "$TC filter add dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf object-file $EBPFDIR/action.o section action-ko",
> + "expExitCode": "1",
> + "verifyCmd": "$TC filter get dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf",
> + "matchPattern": "filter parent ffff: protocol ip pref 100 bpf chain [0-9]+ handle 0x1 action.o:\\[action-ko\\].*tag [0-9a-f]{16}( jited)?",
> + "matchCount": "0",
> + "teardown": [
> + "$TC qdisc del dev $DEV1 ingress"
> + ]
> + },
> + {
> + "id": "4423",
> + "name": "Replace cBPF bytecode",
> + "category": [
> + "filter",
> + "bpf-filter"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$TC qdisc add dev $DEV1 ingress",
> + [
> + "$TC filter add dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf bytecode '4,40 0 0 12,21 0 1 2048,6 0 0 262144,6 0 0 0'",
> + 0,
> + 1,
> + 255
> + ]
> + ],
> + "cmdUnderTest": "$TC filter replace dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf bytecode '4,40 0 0 12,21 0 1 2054,6 0 0 262144,6 0 0 0'",
> + "expExitCode": "0",
> + "verifyCmd": "$TC filter get dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf",
> + "matchPattern": "filter parent ffff: protocol ip pref 100 bpf chain [0-9]+ handle 0x1.*bytecode '4,40 0 0 12,21 0 1 2054,6 0 0 262144,6 0 0 0'",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DEV1 ingress"
> + ]
> + },
> + {
> + "id": "5122",
> + "name": "Delete cBPF filter",
> + "category": [
> + "filter",
> + "bpf-filter"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$TC qdisc add dev $DEV1 ingress",
> + [
> + "$TC filter add dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf bytecode '4,40 0 0 12,21 0 1 2048,6 0 0 262144,6 0 0 0'",
> + 0,
> + 1,
> + 255
> + ]
> + ],
> + "cmdUnderTest": "$TC filter del dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf",
> + "expExitCode": "0",
> + "verifyCmd": "$TC filter get dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf",
> + "matchPattern": "filter parent ffff: protocol ip pref 100 bpf chain [0-9]+ handle 0x1.*bytecode '4,40 0 0 12,21 0 1 2048,6 0 0 262144,6 0 0 0'",
> + "matchCount": "0",
> + "teardown": [
> + "$TC qdisc del dev $DEV1 ingress"
> + ]
> + },
> + {
> + "id": "e0a9",
> + "name": "List cBPF filters",
> + "category": [
> + "filter",
> + "bpf-filter"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$TC qdisc add dev $DEV1 ingress",
> + "$TC filter add dev $DEV1 parent ffff: handle 1 protocol ip prio 100 bpf bytecode '4,40 0 0 12,21 0 1 2048,6 0 0 262144,6 0 0 0'",
> + "$TC filter add dev $DEV1 parent ffff: handle 2 protocol ip prio 100 bpf bytecode '4,40 0 0 12,21 0 1 2054,6 0 0 262144,6 0 0 0'",
> + "$TC filter add dev $DEV1 parent ffff: handle 100 protocol ip prio 100 bpf bytecode '4,40 0 0 12,21 0 1 33024,6 0 0 262144,6 0 0 0'"
> + ],
> + "cmdUnderTest": "$TC filter show dev $DEV1 parent ffff:",
> + "expExitCode": "0",
> + "verifyCmd": "$TC filter show dev $DEV1 parent ffff:",
> + "matchPattern": "filter protocol ip pref 100 bpf chain [0-9]+ handle",
> + "matchCount": "3",
> + "teardown": [
> + "$TC qdisc del dev $DEV1 ingress"
> + ]
> + }
> +]
next prev parent reply other threads:[~2022-09-15 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 6:30 [PATCH net-next,v3 0/9] refactor duplicate codes in the tc cls walk function Zhengchao Shao
2022-09-15 6:30 ` [PATCH net-next,v3 1/9] net/sched: cls_api: add helper for tc cls walker stats updating Zhengchao Shao
2022-09-15 23:23 ` Cong Wang
2022-09-16 1:58 ` shaozhengchao
2022-09-15 6:30 ` [PATCH net-next,v3 2/9] net/sched: use tc_cls_stats_update() in filter Zhengchao Shao
2022-09-15 6:30 ` [PATCH net-next,v3 3/9] selftests/tc-testings: add selftests for bpf filter Zhengchao Shao
2022-09-15 16:00 ` Victor Nogueira [this message]
2022-09-15 6:30 ` [PATCH net-next,v3 4/9] selftests/tc-testings: add selftests for cgroup filter Zhengchao Shao
2022-09-15 6:30 ` [PATCH net-next,v3 5/9] selftests/tc-testings: add selftests for flow filter Zhengchao Shao
2022-09-15 6:30 ` [PATCH net-next,v3 6/9] selftests/tc-testings: add selftests for route filter Zhengchao Shao
2022-09-15 6:30 ` [PATCH net-next,v3 7/9] selftests/tc-testings: add selftests for rsvp filter Zhengchao Shao
2022-09-15 6:30 ` [PATCH net-next,v3 8/9] selftests/tc-testings: add selftests for tcindex filter Zhengchao Shao
2022-09-15 6:30 ` [PATCH net-next,v3 9/9] selftests/tc-testings: add list case for basic filter Zhengchao Shao
2022-09-15 16:00 ` [PATCH net-next,v3 0/9] refactor duplicate codes in the tc cls walk function Victor Nogueira
2022-09-16 1:59 ` shaozhengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c5d6f5f-9fc9-a184-1412-182106bb7a77@mojatatu.com \
--to=victor@mojatatu.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=shaozhengchao@huawei.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yhs@fb.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).