From: Eric Dumazet <eric.dumazet@gmail.com>
To: Gatis Peisenieks <gatis@mikrotik.com>,
chris.snook@gmail.com, davem@davemloft.net, kuba@kernel.org,
hkallweit1@gmail.com, jesse.brandeburg@intel.com,
dchickles@marvell.com, tully@mikrotik.com,
eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4] atl1c: move tx cleanup processing out of interrupt
Date: Wed, 7 Apr 2021 18:55:47 +0200 [thread overview]
Message-ID: <7c5dad3e-950d-8ec9-8b9d-bbce41fafaa4@gmail.com> (raw)
In-Reply-To: <c8327d4bb516dd4741878c64fa6485cd@mikrotik.com>
On 4/6/21 4:49 PM, Gatis Peisenieks wrote:
> Tx queue cleanup happens in interrupt handler on same core as rx queue
> processing. Both can take considerable amount of processing in high
> packet-per-second scenarios.
>
> Sending big amounts of packets can stall the rx processing which is unfair
> and also can lead to out-of-memory condition since __dev_kfree_skb_irq
> queues the skbs for later kfree in softirq which is not allowed to happen
> with heavy load in interrupt handler.
>
[ ... ]
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 0f72ff5d34ba..489ac60b530c 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6789,6 +6789,7 @@ int dev_set_threaded(struct net_device *dev, bool threaded)
>
> return err;
> }
> +EXPORT_SYMBOL(dev_set_threaded);
>
> void netif_napi_add(struct net_device *dev, struct napi_struct *napi,
> int (*poll)(struct napi_struct *, int), int weight)
This has already been done in net-next
Please base your patch on top of net-next, this can not be backported to old
versions anyway, without some amount of pain.
next prev parent reply other threads:[~2021-04-07 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 14:49 [PATCH net v4] atl1c: move tx cleanup processing out of interrupt Gatis Peisenieks
2021-04-06 23:44 ` David Miller
2021-04-07 16:55 ` Eric Dumazet [this message]
2021-04-08 5:21 ` Gatis Peisenieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c5dad3e-950d-8ec9-8b9d-bbce41fafaa4@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=gatis@mikrotik.com \
--cc=hkallweit1@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tully@mikrotik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).