From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
netdev@vger.kernel.org, eli@mellanox.com
Subject: Re: [PATCH V2 4/4] virtio/vdpa: clear the virtqueue state during probe
Date: Wed, 2 Jun 2021 15:07:00 +0800 [thread overview]
Message-ID: <7ce52bd6-60b7-b733-9881-682cfba51ad8@redhat.com> (raw)
In-Reply-To: <20210602061723.GB8662@mtl-vdi-166.wap.labs.mlnx>
在 2021/6/2 下午2:17, Eli Cohen 写道:
> On Wed, Jun 02, 2021 at 10:10:43AM +0800, Jason Wang wrote:
>> From: Eli Cohen <elic@nvidia.com>
>>
>> Clear the available index as part of the initialization process to
>> clear and values that might be left from previous usage of the device.
>> For example, if the device was previously used by vhost_vdpa and now
>> probed by vhost_vdpa, you want to start with indices.
>>
>> Fixes: c043b4a8cf3b ("virtio: introduce a vDPA based transport")
>> Signed-off-by: Eli Cohen <elic@nvidia.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>> drivers/virtio/virtio_vdpa.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
>> index e28acf482e0c..e1a141135992 100644
>> --- a/drivers/virtio/virtio_vdpa.c
>> +++ b/drivers/virtio/virtio_vdpa.c
>> @@ -142,6 +142,8 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
>> struct vdpa_callback cb;
>> struct virtqueue *vq;
>> u64 desc_addr, driver_addr, device_addr;
>> + /* Assume split virtqueue, switch to packed if necessary */
>> + struct vdpa_vq_state state = {0};
>> unsigned long flags;
>> u32 align, num;
>> int err;
>> @@ -191,6 +193,19 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
>> goto err_vq;
>> }
>>
>> + /* reset virtqueue state index */
>> + if (virtio_has_feature(vdev, VIRTIO_F_RING_PACKED)) {
>> + struct vdpa_vq_state_packed *s = &state.packed;
>> +
>> + s->last_avail_counter = 1;
>> + s->last_avail_idx = 0;
> It's already 0
>
>> + s->last_used_counter = 1;
>> + s->last_used_idx = 0;
> already 0
Yes, but for completeness and make code easy to read, it's no harm to
keep them I think.
Thanks
>
>> + }
>> + err = ops->set_vq_state(vdpa, index, &state);
>> + if (err)
>> + goto err_vq;
>> +
>> ops->set_vq_ready(vdpa, index, 1);
>>
>> vq->priv = info;
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2021-06-02 7:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 2:10 [PATCH V2 0/4] Jason Wang
2021-06-02 2:10 ` [PATCH V2 1/4] vdpa: support packed virtqueue for set/get_vq_state() Jason Wang
2021-06-02 2:10 ` [PATCH V2 2/4] virtio-pci library: introduce vp_modern_get_driver_features() Jason Wang
2021-06-02 2:10 ` [PATCH V2 3/4] vp_vdpa: allow set vq state to initial state after reset Jason Wang
2021-06-02 6:13 ` Eli Cohen
2021-06-02 7:05 ` Jason Wang
2021-06-02 7:42 ` Eli Cohen
2021-06-02 2:10 ` [PATCH V2 4/4] virtio/vdpa: clear the virtqueue state during probe Jason Wang
2021-06-02 6:17 ` Eli Cohen
2021-06-02 7:07 ` Jason Wang [this message]
2021-06-02 7:43 ` Eli Cohen
2021-06-02 2:15 ` [PATCH V2 0/4] Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ce52bd6-60b7-b733-9881-682cfba51ad8@redhat.com \
--to=jasowang@redhat.com \
--cc=eli@mellanox.com \
--cc=elic@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).