From: Victor Julien <victor@inliniac.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Network Development <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>,
Eric Dumazet <edumazet@google.com>,
Mao Wenan <maowenan@huawei.com>, Arnd Bergmann <arnd@arndb.de>,
Neil Horman <nhorman@tuxdriver.com>,
linux-doc@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Alexander Drozdov <al.drozdov@gmail.com>,
Tom Herbert <tom@herbertland.com>
Subject: Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good
Date: Tue, 2 Jun 2020 21:47:10 +0200 [thread overview]
Message-ID: <7ce5ae2a-4bce-99af-4fd7-900e6caa8f89@inliniac.net> (raw)
In-Reply-To: <20200602122954.0c35072b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On 02-06-2020 21:29, Jakub Kicinski wrote:
> On Tue, 2 Jun 2020 21:22:11 +0200 Victor Julien wrote:
>> - receiver uses nfp (netronome) driver: TP_STATUS_CSUM_VALID set for
>> every packet, including the bad TCP ones
>> - receiver uses ixgbe driver: TP_STATUS_CSUM_VALID not set for the bad
>> packets.
>>
>> Again purely based on 'git grep' it seems nfp does not support
>> UNNECESSARY, while ixgbe does.
>>
>> (my original testing was with the nfp only, so now I at least understand
>> my original thinking)
>
> FWIW nfp defaults to CHECKSUM_COMPLETE if the device supports it (see
> if you have RXCSUM_COMPLETE in the probe logs). It supports UNNECESSARY
> as well, but IDK if there is a way to choose the preferred checksum
> types in the stack :( You'd have to edit the driver and remove the
> NFP_NET_CFG_CTRL_CSUM_COMPLETE from the NFP_NET_CFG_CTRL_RXCSUM_ANY
> mask to switch to using UNNECESSARY.
>
I indeed have RXCSUM_COMPLETE, so that should mean it uses
CHECKSUM_COMPLETE indeed.
nfp 0000:43:00.0 eth0: CAP: 0x78140233 PROMISC RXCSUM TXCSUM GATHER TSO2
RSS2 AUTOMASK IRQMOD RXCSUM_COMPLETE
--
---------------------------------------------
Victor Julien
http://www.inliniac.net/
PGP: http://www.inliniac.net/victorjulien.asc
---------------------------------------------
next prev parent reply other threads:[~2020-06-02 19:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 8:05 [PATCH net-next v2] af-packet: new flag to indicate all csums are good Victor Julien
2020-06-02 8:11 ` Victor Julien
2020-06-02 14:29 ` Willem de Bruijn
2020-06-02 17:03 ` Victor Julien
2020-06-02 17:37 ` Willem de Bruijn
2020-06-02 18:31 ` Victor Julien
2020-06-02 19:03 ` Willem de Bruijn
2020-06-02 19:22 ` Victor Julien
2020-06-02 19:29 ` Jakub Kicinski
2020-06-02 19:47 ` Victor Julien [this message]
2020-06-02 19:38 ` Willem de Bruijn
2020-06-02 20:05 ` Victor Julien
2020-06-02 20:18 ` Willem de Bruijn
2020-06-02 20:29 ` Victor Julien
2020-06-04 9:46 ` Victor Julien
2020-06-04 13:48 ` Willem de Bruijn
2020-06-05 12:38 ` Victor Julien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ce5ae2a-4bce-99af-4fd7-900e6caa8f89@inliniac.net \
--to=victor@inliniac.net \
--cc=al.drozdov@gmail.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tom@herbertland.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).