From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Andrew Halaney <ahalaney@redhat.com>, linux-kernel@vger.kernel.org
Cc: agross@kernel.org, andersson@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
vkoul@kernel.org, bhupesh.sharma@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, linux@armlinux.org.uk,
veekhee@apple.com, tee.min.tan@linux.intel.com,
mohammad.athari.ismail@intel.com, jonathanh@nvidia.com,
ruppala@nvidia.com, bmasney@redhat.com,
andrey.konovalov@linaro.org, linux-arm-msm@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ncai@quicinc.com,
jsuraj@qti.qualcomm.com, hisunil@quicinc.com,
echanude@redhat.com
Subject: Re: [PATCH net-next v2 06/12] arm64: dts: qcom: sc8280xp: Add ethernet nodes
Date: Tue, 21 Mar 2023 20:33:47 +0100 [thread overview]
Message-ID: <7d4f9662-2eb1-e2d2-193c-e6453dc7b93b@linaro.org> (raw)
In-Reply-To: <20230320221617.236323-7-ahalaney@redhat.com>
On 20.03.2023 23:16, Andrew Halaney wrote:
> This platform has 2 MACs integrated in it, go ahead and describe them.
>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
>
> Changes since v1:
> * None
>
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 53 ++++++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 0d02599d8867..a63e8e81a8c4 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -761,6 +761,59 @@ soc: soc@0 {
> ranges = <0 0 0 0 0x10 0>;
> dma-ranges = <0 0 0 0 0x10 0>;
>
> + ethernet0: ethernet@20000 {
> + compatible = "qcom,sc8280xp-ethqos";
> + reg = <0x0 0x00020000 0x0 0x10000>,
> + <0x0 0x00036000 0x0 0x100>;
Please correct the indentation here.
> + reg-names = "stmmaceth", "rgmii";
> +
> + clocks = <&gcc GCC_EMAC0_AXI_CLK>,
> + <&gcc GCC_EMAC0_SLV_AHB_CLK>,
> + <&gcc GCC_EMAC0_PTP_CLK>,
> + <&gcc GCC_EMAC0_RGMII_CLK>;
Please correct the indentation here.
> + clock-names = "stmmaceth", "pclk", "ptp_ref", "rgmii";
Please turn this into a vertical list.
> +
> + interrupts = <GIC_SPI 946 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 936 IRQ_TYPE_LEVEL_HIGH>;
Please correct the indentation here.
Same for the other node.
Konrad
> + interrupt-names = "macirq", "eth_lpi";
> + iommus = <&apps_smmu 0x4c0 0xf>;
> + power-domains = <&gcc EMAC_0_GDSC>;
> +
> + snps,tso;
> + snps,pbl = <32>;
> + rx-fifo-depth = <4096>;
> + tx-fifo-depth = <4096>;
> +
> + status = "disabled";
> + };
> +
> + ethernet1: ethernet@23000000 {
> + compatible = "qcom,sc8280xp-ethqos";
> + reg = <0x0 0x23000000 0x0 0x10000>,
> + <0x0 0x23016000 0x0 0x100>;
> + reg-names = "stmmaceth", "rgmii";
> +
> + clocks = <&gcc GCC_EMAC1_AXI_CLK>,
> + <&gcc GCC_EMAC1_SLV_AHB_CLK>,
> + <&gcc GCC_EMAC1_PTP_CLK>,
> + <&gcc GCC_EMAC1_RGMII_CLK>;
> + clock-names = "stmmaceth", "pclk", "ptp_ref", "rgmii";
> +
> + interrupts = <GIC_SPI 929 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 919 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_lpi";
> +
> + iommus = <&apps_smmu 0x40 0xf>;
> + power-domains = <&gcc EMAC_1_GDSC>;
> +
> + snps,tso;
> + snps,pbl = <32>;
> + rx-fifo-depth = <4096>;
> + tx-fifo-depth = <4096>;
> +
> + status = "disabled";
> + };
> +
> gcc: clock-controller@100000 {
> compatible = "qcom,gcc-sc8280xp";
> reg = <0x0 0x00100000 0x0 0x1f0000>;
next prev parent reply other threads:[~2023-03-21 19:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 22:16 [PATCH net-next v2 00/12] Add EMAC3 support for sa8540p-ride Andrew Halaney
2023-03-20 22:16 ` [PATCH net-next v2 01/12] dt-bindings: net: snps,dwmac: Update interrupt-names Andrew Halaney
2023-03-21 6:46 ` Krzysztof Kozlowski
2023-03-20 22:16 ` [PATCH net-next v2 02/12] dt-bindings: net: snps,dwmac: Add Qualcomm Ethernet ETHQOS compatibles Andrew Halaney
2023-03-20 22:16 ` [PATCH net-next v2 03/12] dt-bindings: net: qcom,ethqos: Convert bindings to yaml Andrew Halaney
2023-03-21 6:47 ` Krzysztof Kozlowski
2023-03-20 22:16 ` [PATCH net-next v2 04/12] dt-bindings: net: qcom,ethqos: Add Qualcomm sc8280xp compatibles Andrew Halaney
2023-03-21 6:47 ` Krzysztof Kozlowski
2023-03-20 22:16 ` [PATCH net-next v2 05/12] clk: qcom: gcc-sc8280xp: Add EMAC GDSCs Andrew Halaney
2023-03-21 19:33 ` Konrad Dybcio
2023-03-20 22:16 ` [PATCH net-next v2 06/12] arm64: dts: qcom: sc8280xp: Add ethernet nodes Andrew Halaney
2023-03-21 19:33 ` Konrad Dybcio [this message]
2023-03-20 22:16 ` [PATCH net-next v2 07/12] arm64: dts: qcom: sa8540p-ride: " Andrew Halaney
2023-03-20 22:16 ` [PATCH net-next v2 08/12] net: stmmac: Remove unnecessary if statement brackets Andrew Halaney
2023-03-20 22:16 ` [PATCH net-next v2 09/12] net: stmmac: Add EMAC3 variant of dwmac4 Andrew Halaney
2023-03-21 3:41 ` Jakub Kicinski
2023-03-21 22:19 ` Andrew Halaney
2023-03-20 22:16 ` [PATCH net-next v2 10/12] net: stmmac: dwmac-qcom-ethqos: Respect phy-mode and TX delay Andrew Halaney
2023-03-21 3:29 ` Jakub Kicinski
2023-03-20 22:16 ` [PATCH net-next v2 11/12] net: stmmac: dwmac-qcom-ethqos: Use loopback_en for all speeds Andrew Halaney
2023-03-20 22:16 ` [PATCH net-next v2 12/12] net: stmmac: dwmac-qcom-ethqos: Add EMAC3 support Andrew Halaney
2023-03-21 3:28 ` [PATCH net-next v2 00/12] Add EMAC3 support for sa8540p-ride Jakub Kicinski
2023-03-21 18:44 ` Andrew Halaney
2023-03-22 2:44 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d4f9662-2eb1-e2d2-193c-e6453dc7b93b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bhupesh.sharma@linaro.org \
--cc=bmasney@redhat.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=echanude@redhat.com \
--cc=edumazet@google.com \
--cc=hisunil@quicinc.com \
--cc=joabreu@synopsys.com \
--cc=jonathanh@nvidia.com \
--cc=jsuraj@qti.qualcomm.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=mturquette@baylibre.com \
--cc=ncai@quicinc.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ruppala@nvidia.com \
--cc=sboyd@kernel.org \
--cc=tee.min.tan@linux.intel.com \
--cc=veekhee@apple.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).