From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C4B1C43613 for ; Thu, 20 Jun 2019 14:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4FF72083B for ; Thu, 20 Jun 2019 14:05:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="FMk4shXH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731823AbfFTOF3 (ORCPT ); Thu, 20 Jun 2019 10:05:29 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:11708 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbfFTOF2 (ORCPT ); Thu, 20 Jun 2019 10:05:28 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 20 Jun 2019 07:05:25 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 20 Jun 2019 07:05:26 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 20 Jun 2019 07:05:26 -0700 Received: from [10.21.132.148] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 20 Jun 2019 14:05:24 +0000 Subject: Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic From: Jon Hunter To: Jose Abreu , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" CC: Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-tegra References: <6226d6a0de5929ed07d64b20472c52a86e71383d.1560266175.git.joabreu@synopsys.com> <78EB27739596EE489E55E81C33FEC33A0B9C8D6E@DE02WEMBXB.internal.synopsys.com> <26cfaeff-a310-3b79-5b57-fd9c93bd8929@nvidia.com> <78EB27739596EE489E55E81C33FEC33A0B9C8DD9@DE02WEMBXB.internal.synopsys.com>

<6f36b6b6-8209-ed98-e7e1-3dac0a92f6cd@nvidia.com> Message-ID: <7f0f2ed0-f47c-4670-d169-25f0413c1fd3@nvidia.com> Date: Thu, 20 Jun 2019 15:05:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <6f36b6b6-8209-ed98-e7e1-3dac0a92f6cd@nvidia.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1561039525; bh=kk0iROuiBw86L8JMDa5UasFqeu4eaEGk4Y4zy76zYa0=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=FMk4shXHyUbeAy1dildJ33Lcn3gZ2iR/fQjUlgiuSdiiES3WHLIV9lz409RfTMOJ1 GtXnMNJB5cYBuyP9R24/pinO1sWsYrELeJiRFD0cQxHHguiE6fbLbuLES3oix3t92n F4eyUg9mbIyrLWFVdpBKvOOTqtffCQ7fwfcq57AhvVP7WxKmCppZvbifhTO7yBd2Tt 8YPZWiSDbZ3AkQkelKGq4TuYmv+wfI4o/Gy9fktBMcI+cW4yt0Rc3Euh+2K5XRiKEF J87DSIyAM6fZQlDOkJA8xeiEqL2R+/JvuSKyj6BornoIZ3E9T5bJz5veXRm/lUVsfB NVigdYX6UlNyQ== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/06/2019 20:44, Jon Hunter wrote: > > On 18/06/2019 16:20, Jon Hunter wrote: >> >> On 18/06/2019 11:18, Jon Hunter wrote: >>> >>> On 18/06/2019 10:46, Jose Abreu wrote: >>>> From: Jon Hunter >>>> >>>>> I am not certain but I don't believe so. We are using a static IP address >>>>> and mounting the root file-system via NFS when we see this ... >>>> >>>> Can you please add a call to napi_synchronize() before every >>>> napi_disable() calls, like this: >>>> >>>> if (queue < rx_queues_cnt) { >>>> napi_synchronize(&ch->rx_napi); >>>> napi_disable(&ch->rx_napi); >>>> } >>>> >>>> if (queue < tx_queues_cnt) { >>>> napi_synchronize(&ch->tx_napi); >>>> napi_disable(&ch->tx_napi); >>>> } >>>> >>>> [ I can send you a patch if you prefer ] >>> >>> Yes I can try this and for completeness you mean ... >>> >>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>> index 4ca46289a742..d4a12cb64d8e 100644 >>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>> @@ -146,10 +146,15 @@ static void stmmac_disable_all_queues(struct stmmac_priv *priv) >>> for (queue = 0; queue < maxq; queue++) { >>> struct stmmac_channel *ch = &priv->channel[queue]; >>> >>> - if (queue < rx_queues_cnt) >>> + if (queue < rx_queues_cnt) { >>> + napi_synchronize(&ch->rx_napi); >>> napi_disable(&ch->rx_napi); >>> - if (queue < tx_queues_cnt) >>> + } >>> + >>> + if (queue < tx_queues_cnt) { >>> + napi_synchronize(&ch->tx_napi); >>> napi_disable(&ch->tx_napi); >>> + } >>> } >>> } >> >> So good news and bad news ... >> >> The good news is that the above change does fix the initial crash >> I am seeing. However, even with this change applied on top of >> -next, it is still dying somewhere else and so there appears to >> be a second issue. > > Further testing has shown that actually this does NOT resolve the issue > and I am still seeing the crash. Sorry for the false-positive. Any further feedback? I am still seeing this issue on today's -next. Thanks Jon -- nvpublic