From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E062EC4727D for ; Thu, 24 Sep 2020 11:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DA8E2311B for ; Thu, 24 Sep 2020 11:36:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="e6W4eeYU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727442AbgIXLg3 (ORCPT ); Thu, 24 Sep 2020 07:36:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:38472 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726701AbgIXLg3 (ORCPT ); Thu, 24 Sep 2020 07:36:29 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1600947387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MZyvBg20qT73QpwIVlDigtRjVhnHdUuTkqO7GvwSeIE=; b=e6W4eeYUCdmzKdxQ7xtoWbgJ9qdgvwr2lNlDirzA5K8Wrebqf2M3M/HUEs+GFMz86GkDnO +SYxT7FpIuIZB1snPQ5GEuM7p9YxWimxBNYh3XwHLw5J+Y/O8gOgEZTtlGoi1WAQufifHL TGzb/bqFAm2cN/kjrzhCyCG1l4fajns= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7D634AC65; Thu, 24 Sep 2020 11:36:27 +0000 (UTC) Message-ID: <7f9e20b2eab783303c4e5f5c3244366fa88a6567.camel@suse.com> Subject: Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send() From: Oliver Neukum To: Himadri Pandya Cc: David Miller , Jakub Kicinski , pankaj.laxminarayan.bharadiya@intel.com, Kees Cook , yuehaibing@huawei.com, petkan@nucleusys.com, ogiannou@gmail.com, USB list , netdev , LKML , linux-kernel-mentees@lists.linuxfoundation.org, Greg KH Date: Thu, 24 Sep 2020 13:13:56 +0200 In-Reply-To: References: <20200923090519.361-1-himadrispandya@gmail.com> <20200923090519.361-4-himadrispandya@gmail.com> <1600856557.26851.6.camel@suse.com> <1600870858.25088.1.camel@suse.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am Mittwoch, den 23.09.2020, 20:02 +0530 schrieb Himadri Pandya: > I meant that it was stupid to change it without properly understanding > the significance of GFP_NOIO in this context. > > So now, do we re-write the wrapper functions with flag passed as a parameter? Hi, I hope I set you in CC for a patch set doing exactly that. Do not let me or other maintainers discourage you from writing patches. Look at it this way. Had you not written this patch, I would not have looked into the matter. Patches are supposed to be reviewed. If you want additional information, just ask. We do not want people discouraged from writing substantial patches. Regards Oliver