From: Shannon Nelson <snelson@pensando.io>
To: "Michael S. Tsirkin" <mst@redhat.com>, jcfaracco@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, jasowang@redhat.com,
virtualization@lists.linux-foundation.org, dnmendes76@gmail.com
Subject: Re: [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler
Date: Tue, 3 Dec 2019 11:47:44 -0800 [thread overview]
Message-ID: <80070eaa-84b2-5f41-db72-d8bf594924fd@pensando.io> (raw)
In-Reply-To: <20191203071101.427592-1-mst@redhat.com>
On 12/2/19 11:12 PM, Michael S. Tsirkin wrote:
> This allows incrementing the correct timeout statistic without any mess.
> Down the road, devices can learn to reset just the specific queue.
>
[...]
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 20faa8d24c9f..f7beb1b9e9d6 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -1268,7 +1268,7 @@ static void ionic_tx_timeout_work(struct work_struct *ws)
> rtnl_unlock();
> }
>
> -static void ionic_tx_timeout(struct net_device *netdev)
> +static void ionic_tx_timeout(struct net_device *netdev, unsigned int txqueue)
> {
> struct ionic_lif *lif = netdev_priv(netdev);
>
>
[...]
For drivers/net/ethernet/pensando/ionic:
Acked-by: Shannon Nelson <snelson@pensando.io>
prev parent reply other threads:[~2019-12-03 19:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 7:12 [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler Michael S. Tsirkin
2019-12-03 7:32 ` [PATCH RFC v7 net-next 2/1] mlx4: use new txqueue timeout argument Michael S. Tsirkin
2019-12-03 7:32 ` [PATCH RFC v7 net-next 3/1] netronome: use the " Michael S. Tsirkin
2019-12-03 18:09 ` Jakub Kicinski
2019-12-03 18:07 ` [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler Jakub Kicinski
2019-12-03 19:24 ` Heiner Kallweit
2019-12-03 19:47 ` Shannon Nelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80070eaa-84b2-5f41-db72-d8bf594924fd@pensando.io \
--to=snelson@pensando.io \
--cc=davem@davemloft.net \
--cc=dnmendes76@gmail.com \
--cc=jasowang@redhat.com \
--cc=jcfaracco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).