From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 589AAC282CE for ; Wed, 13 Feb 2019 20:11:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2AA3E2147C for ; Wed, 13 Feb 2019 20:11:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sNOaCshk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388690AbfBMULs (ORCPT ); Wed, 13 Feb 2019 15:11:48 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43319 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfBMULs (ORCPT ); Wed, 13 Feb 2019 15:11:48 -0500 Received: by mail-pl1-f194.google.com with SMTP id f90so1717365plb.10 for ; Wed, 13 Feb 2019 12:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mgj++qAp1pmW48/+5ue1Pba7eLAPHwUMfGKbOkE50BQ=; b=sNOaCshk/f3tAoCrvWxW7rDj2+K2V21ZAP18bwJs2puxk/QpAvtBI6qBQAtozo40dU w8SgYEJgFmkPziahGRANTl+lW64X16+/iTvTRxNx9erX5Jx+arf2HMzPb0PB8fGSa5cP qifBcqzxZ7+Vd/Uws7GigTu3bhTeKOaj5e8vbrURJWsKV5TNPyimjyBL7KlEXXPF6Vf+ z8zArAyM+Y/iU0L//fRZBBfA+ZPOCKyfAWOiI08fbbodIk3iysXKSq58r1376o2k4iR5 Q+RrkU+8vZ7YSHpSWDSQ1S5JFJm/gqlcD8vrtblU5R7GJGI+9g9aewE8UdG7EIe3Fxrm hZmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mgj++qAp1pmW48/+5ue1Pba7eLAPHwUMfGKbOkE50BQ=; b=pqaR9LP4mvdJXaqKhiMQ3hO/ucvbfhjjdaplPKZYqvBErSTcHYJaYzjJDRMcVwPUSy 246uftRLgG7NgUP7zXwH0GGrIyLeInn+5gXmmN081Xlw/wFzn0Zi45c70A3A1n/ryH+9 arO59EjEpoIzSf3iKf4a8a6/Rokqzd1Su72O7Mu4VZSldMinGQbaOBHlO53wCe8ZoWYH zjJHXI+tgRDTH2RQ+gyX4slD7c8qO1Hee3ZOE0+somBCB8X5LkjZj8/MOYtQF3Z2tP67 7xhCuWL5d4l/hsQrqliLr7TPDeDPRZRp+8Ms+TFDVAva4vVodj8RNU/oPk80ZoInvrkL GCjg== X-Gm-Message-State: AHQUAubbBQaGh1Q5esjsoh2sp133AGTHNkwJpZmgKm5ozMi0hzLx/UPL Cqe1PEMVp6N4vKHNIyTJQB0= X-Google-Smtp-Source: AHgI3IYuQEqmym/lYMPazYE8PcE+pfXnnxdNCkMCvJ4DCYyUUgCtSuJcskdflu3SNHZh0lYs3yfsHQ== X-Received: by 2002:a17:902:8690:: with SMTP id g16mr2288431plo.81.1550088708037; Wed, 13 Feb 2019 12:11:48 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:1d6b:31d6:ccdb:d65a? ([2601:282:800:fd80:1d6b:31d6:ccdb:d65a]) by smtp.googlemail.com with ESMTPSA id a13sm176557pgw.34.2019.02.13.12.11.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 12:11:47 -0800 (PST) Subject: Re: [PATCH bpf-next v10 5/7] bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c To: Peter Oskolkov Cc: Alexei Starovoitov , Daniel Borkmann , netdev , Peter Oskolkov , Willem de Bruijn References: <20190212173247.121342-1-posk@google.com> <20190212173247.121342-6-posk@google.com> <681aca28-b4e5-eb0d-46cd-94db7a2c368c@gmail.com> From: David Ahern Message-ID: <80849fb5-c5de-ce6b-6c25-bd152326196c@gmail.com> Date: Wed, 13 Feb 2019 13:11:45 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/13/19 12:57 PM, Peter Oskolkov wrote: > Thanks, David! I was not able to reproduce the leak, but based on your > suggestion and similar code elsewhere I made a change in v11 to explicitly > release a dst with error. ok. Did you run the test with a debug kernel - checking refcount, use after free, etc?