From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yanhong Wang <yanhong.wang@starfivetech.com>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v3 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names
Date: Fri, 6 Jan 2023 13:38:38 +0100 [thread overview]
Message-ID: <80c9fac7-36fe-293e-62f0-945515b8f481@linaro.org> (raw)
In-Reply-To: <20230106030001.1952-3-yanhong.wang@starfivetech.com>
On 06/01/2023 03:59, Yanhong Wang wrote:
> Some boards(such as StarFive VisionFive v2) require more than one value
> which defined by resets property, so the original definition can not
> meet the requirements. In order to adapt to different requirements,
> adjust the maxitems number definition.
>
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 36 ++++++++++++++-----
> 1 file changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index e26c3e76ebb7..f7693e8c8d6d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -132,14 +132,6 @@ properties:
> - pclk
> - ptp_ref
>
> - resets:
> - maxItems: 1
> - description:
> - MAC Reset signal.
> -
> - reset-names:
> - const: stmmaceth
Do not remove properties from top-level properties. Instead these should
have widest constraints which are further constrain in allOf:if:then.
Here you should list items with minItems: 1.
> -
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-06 12:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 2:59 [PATCH v3 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2023-01-06 2:59 ` [PATCH v3 1/7] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang
2023-01-06 12:37 ` Krzysztof Kozlowski
2023-01-06 2:59 ` [PATCH v3 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang
2023-01-06 12:38 ` Krzysztof Kozlowski [this message]
2023-01-06 12:44 ` Krzysztof Kozlowski
2023-01-17 6:52 ` yanhong wang
2023-01-17 7:46 ` Krzysztof Kozlowski
2023-01-17 8:14 ` yanhong wang
2023-01-17 8:43 ` Krzysztof Kozlowski
2023-01-06 2:59 ` [PATCH v3 3/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2023-01-06 2:59 ` [PATCH v3 4/7] dt-bindings: net: Add support StarFive dwmac Yanhong Wang
2023-01-06 12:45 ` Krzysztof Kozlowski
2023-01-18 1:45 ` yanhong wang
2023-01-18 8:00 ` Krzysztof Kozlowski
2023-01-06 2:59 ` [PATCH v3 5/7] net: stmmac: Add glue layer for StarFive JH7110 SoCs Yanhong Wang
2023-01-08 11:11 ` Arun.Ramadoss
2023-01-09 1:13 ` yanhong wang
2023-01-06 3:00 ` [PATCH v3 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2023-01-06 3:00 ` [PATCH v3 7/7] riscv: dts: starfive: visionfive-v2: Enable gmac device tree node Yanhong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80c9fac7-36fe-293e-62f0-945515b8f481@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).