From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C41CCA9EC0 for ; Tue, 29 Oct 2019 01:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 621D821479 for ; Tue, 29 Oct 2019 01:36:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="G+I4lHua"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="G+I4lHua" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728570AbfJ2Bgh (ORCPT ); Mon, 28 Oct 2019 21:36:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37128 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727703AbfJ2Bgh (ORCPT ); Mon, 28 Oct 2019 21:36:37 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 89F2960D82; Tue, 29 Oct 2019 01:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572312996; bh=Mv2J845sZ1e4fsPYWzkhpXf5jScuwP+p1t+8zgQxR5o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G+I4lHua2nOIO1gBo7zGQLd+Bm6sdsQKImmPFIWu5d/+EZGNGbyIOIaPvPPM6pYgF 00Hy58QcPgLkV6DzNA00dAr+OJxojNmSoEj9viS9zF+2nGN6gcobcqzs0glTugc5DV tf3avWuT0/uU5FIl8Z/aZGAV9r0aIVpsDzDw1PT8= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 21AC36081E; Tue, 29 Oct 2019 01:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572312996; bh=Mv2J845sZ1e4fsPYWzkhpXf5jScuwP+p1t+8zgQxR5o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G+I4lHua2nOIO1gBo7zGQLd+Bm6sdsQKImmPFIWu5d/+EZGNGbyIOIaPvPPM6pYgF 00Hy58QcPgLkV6DzNA00dAr+OJxojNmSoEj9viS9zF+2nGN6gcobcqzs0glTugc5DV tf3avWuT0/uU5FIl8Z/aZGAV9r0aIVpsDzDw1PT8= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 28 Oct 2019 19:36:36 -0600 From: Subash Abhinov Kasiviswanathan To: Neal Cardwell Cc: Netdev , Yuchung Cheng , Eric Dumazet Subject: Re: Crash when receiving FIN-ACK in TCP_FIN_WAIT1 state In-Reply-To: References: <68ad6fb82c0edfb788c7ce1a3bdc851b@codeaurora.org> <2279a8988c3f37771dda5593b350d014@codeaurora.org> Message-ID: <81ace6052228e12629f73724236ade63@codeaurora.org> X-Sender: subashab@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org >> I've queued up a build which logs calls to tcp_write_queue_purge and >> clears tp->highest_sack and tp->sacked_out. I will let you know how >> it fares by end of week. > > OK, thanks. That should be a useful data point. I haven't seen the crash in the testing so far. Looks like clearing these values seems to help. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project