From: "Vaittinen, Matti (EXT-Other - FI/Oulu)" <matti.vaittinen.ext@nsn.com>
To: "ext Stephen Hemminger" <stephen.hemminger@vyatta.com>,
"David Miller" <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: RE: [PATCH] IPv6: NLM_F_* flag support for route creation/changing when using netlink.
Date: Thu, 27 Oct 2011 10:20:46 +0300 [thread overview]
Message-ID: <82C9FC7ED59434458AD4E09AFF2DE230BF09EE@FIESEXC006.nsn-intra.net> (raw)
In-Reply-To: <9b43e0ef-21cf-4062-b998-849e9e8d6b56@tahiti.vyatta.com>
> -----Original Message-----
> From: ext Stephen Hemminger [mailto:stephen.hemminger@vyatta.com]
> Sent: Thursday, October 27, 2011 10:12 AM
> To: David Miller
> Cc: netdev@vger.kernel.org; Vaittinen, Matti (EXT-Other - FI/Oulu)
> Subject: Re: [PATCH] IPv6: NLM_F_* flag support for route
creation/changing when using netlink.
>
>
> > From: "Vaittinen, Matti (EXT-Other - FI/Oulu)"
> > <matti.vaittinen.ext@nsn.com>
> > Date: Thu, 27 Oct 2011 09:26:05 +0300
> >
> > >
> > > Will requiring NLM_F_CREATE break lots of existing userspace
> > > software?
> >
> > I can almost guarenetee that since we haven't been requiring this,
it
> > will break almost everything.
>
> Why not just make it a kernel warning for several releases.
>
> Just checked, and iproute and quagga will have no problem since they
both already pass the CREATE flag.
For me kernel warning sounds like a reasonable approach. I will change
the patch to not drop the request with error, but to issue a warning
instead. I'll also try using better email client next time.
Furthermore I believe that most tools used for both IPv4 and IPv6
routing (like iproute) do add the CREATE flag because IPv4 route
creation does require it.
prev parent reply other threads:[~2011-10-27 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 6:26 [PATCH] IPv6: NLM_F_* flag support for route creation/changing when using netlink Vaittinen, Matti (EXT-Other - FI/Oulu)
2011-10-27 7:06 ` David Miller
2011-10-27 7:12 ` Stephen Hemminger
2011-10-27 7:20 ` Vaittinen, Matti (EXT-Other - FI/Oulu) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82C9FC7ED59434458AD4E09AFF2DE230BF09EE@FIESEXC006.nsn-intra.net \
--to=matti.vaittinen.ext@nsn.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).