netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Vladyslav Buslov <vladbu@nvidia.com>
Cc: Jianlin Shi <jishi@redhat.com>,
	CKI Project <cki-project@redhat.com>,
	netdev <netdev@vger.kernel.org>,
	skt-results-master@redhat.com, Yi Zhang <yi.zhang@redhat.com>,
	Memory Management <mm-qe@redhat.com>,
	Jan Stancek <jstancek@redhat.com>, Jianwen Ji <jiji@redhat.com>,
	Hangbin Liu <haliu@redhat.com>, Ondrej Moris <omoris@redhat.com>,
	Ondrej Mosnacek <omosnace@redhat.com>,
	Changhui Zhong <czhong@redhat.com>, Xiong Zhou <xzhou@redhat.com>,
	Rachel Sibley <rasibley@redhat.com>,
	David Arcari <darcari@redhat.com>
Subject: Re: ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org)
Date: Wed, 09 Dec 2020 10:34:35 -0800	[thread overview]
Message-ID: <838391ff7ffa5dbfb79f30c6d31292c80415af18.camel@kernel.org> (raw)
In-Reply-To: <CANn89iKcKATT902n6C1-Hi0ey0Ep20dD88nTTLLH9NNF6Pex5w@mail.gmail.com>

On Wed, 2020-12-09 at 19:05 +0100, Eric Dumazet wrote:
> On Wed, Dec 9, 2020 at 6:35 PM Eric Dumazet <edumazet@google.com>
> wrote:
> > Hmm... maybe the ECN stuff has always been buggy then, and nobody
> > cared...
> > 
> 
> Wait a minute, maybe this part was not needed,
> 
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index
> 8ae9ce2014a4a3ba7b962a209e28d1f65d4a83bd..896a7eb61d70340f69b9d3be0f7
> 95fbaab1458dd
> 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -270,7 +270,7 @@ static void geneve_rx(struct geneve_dev *geneve,
> struct geneve_sock *gs,
>                         goto rx_error;
>                 break;
>         default:
> -               goto rx_error;
> +               break;
>         }
>         oiph = skb_network_header(skb);
>         skb_reset_network_header(skb);
> 
> 
> > On Wed, Dec 9, 2020 at 6:20 PM Jakub Kicinski <kuba@kernel.org>
> > wrote:
> > > Eric, could this possibly be commit 4179b00c04d1 ("geneve: pull
> > > IP
> > > header before ECN decapsulation")?
> > > 

We've bisected an issue in our CI to this patch, something about geneve
TC offload traffic not passing, I don't have all the details, Maybe
Vlad can chime in.



  reply	other threads:[~2020-12-09 18:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cki.4066A31294.UNMQ21P718@redhat.com>
     [not found] ` <CABE0yyi9gS8nao0n1Dts_Og80R71h8PUkizy4rM9E9E3QbJwvA@mail.gmail.com>
2020-12-09  2:05   ` ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org) Jianlin Shi
2020-12-09 17:20     ` Jakub Kicinski
2020-12-09 17:35       ` Eric Dumazet
2020-12-09 18:05         ` Eric Dumazet
2020-12-09 18:34           ` Saeed Mahameed [this message]
2020-12-09 18:50             ` Eric Dumazet
2020-12-09 20:54               ` Vlad Buslov
2020-12-09 21:07                 ` Eric Dumazet
2020-12-09 22:50                   ` Jakub Kicinski
2020-12-09 22:22                 ` Jakub Kicinski
2020-12-10  8:35                   ` Vlad Buslov
2020-12-10  9:54                     ` Eric Dumazet
2021-03-30 13:22                     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838391ff7ffa5dbfb79f30c6d31292c80415af18.camel@kernel.org \
    --to=saeed@kernel.org \
    --cc=cki-project@redhat.com \
    --cc=czhong@redhat.com \
    --cc=darcari@redhat.com \
    --cc=edumazet@google.com \
    --cc=haliu@redhat.com \
    --cc=jiji@redhat.com \
    --cc=jishi@redhat.com \
    --cc=jstancek@redhat.com \
    --cc=kuba@kernel.org \
    --cc=mm-qe@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=omoris@redhat.com \
    --cc=omosnace@redhat.com \
    --cc=rasibley@redhat.com \
    --cc=skt-results-master@redhat.com \
    --cc=vladbu@nvidia.com \
    --cc=xzhou@redhat.com \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).