From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD97C43613 for ; Fri, 21 Jun 2019 18:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 941342083B for ; Fri, 21 Jun 2019 18:33:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726402AbfFUSdc (ORCPT ); Fri, 21 Jun 2019 14:33:32 -0400 Received: from smtprelay0111.hostedemail.com ([216.40.44.111]:43146 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726032AbfFUSdc (ORCPT ); Fri, 21 Jun 2019 14:33:32 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 3DF02837F24D; Fri, 21 Jun 2019 18:33:30 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: value78_13e1d23df325 X-Filterd-Recvd-Size: 3044 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Fri, 21 Jun 2019 18:33:28 +0000 (UTC) Message-ID: <838b8e84523151418ab8cda4abdbb114ce24a497.camel@perches.com> Subject: Re: [PATCH 0/3] net: ethernet: atheros: atlx: Use PCI generic definitions instead of private duplicates From: Joe Perches To: Bjorn Helgaas Cc: Puranjay Mohan , Jay Cliburn , Chris Snook , Shuah Khan , Bjorn Helgaas , netdev , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Linux PCI Date: Fri, 21 Jun 2019 11:33:27 -0700 In-Reply-To: References: <20190621163921.26188-1-puranjay12@gmail.com> <698d3e3614ae903ae9582547d64c6a9846629e57.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2019-06-21 at 13:12 -0500, Bjorn Helgaas wrote: > On Fri, Jun 21, 2019 at 12:27 PM Joe Perches wrote: [] > > Subsystem specific local PCI #defines without generic > > naming is poor style and makes treewide grep and > > refactoring much more difficult. > > Don't worry, we have the same objectives. I totally agree that local > #defines are a bad thing, which is why I proposed this project in the > first place. Hi again Bjorn. I didn't know that was your idea. Good idea. > I'm just saying that this is a "first-patch" sort of learning project > and I think it'll avoid some list spamming and discouragement if we > can figure out the scope and shake out some of the teething problems > ahead of time. I don't want to end up with multiple versions of > dozens of little 2-3 patch series posted every week or two. Great, that's sensible. > I'd rather be able to deal with a whole block of them at one time. Also very sensible. > > 2: Show that you compiled the object files and verified > > where possible that there are no object file changes. > > Do you have any pointers for the best way to do this? Is it as simple > as comparing output of "objdump -d"? Generically, yes. I have a little script that does the equivalent of: make mv .old patch -P1 < make mv .new diff -urN <(objdump -d .old) <(objdump -d .new) But it's not foolproof as gcc does not guarantee compilation repeatability. And some subsystems Makefiles do not allow per-file compilation.