From: Marcel Holtmann <marcel@holtmann.org>
To: Archie Pusaka <apusaka@google.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
Archie Pusaka <apusaka@chromium.org>,
Alain Michaud <alainm@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1] Bluetooth: send proper config param to unknown config request
Date: Fri, 25 Sep 2020 18:11:27 +0200 [thread overview]
Message-ID: <83EE8429-0454-4348-9FDA-AC275C3D5B8E@holtmann.org> (raw)
In-Reply-To: <20200924234422.v1.1.Id1d24a896cd1d20f9ce7a4eb74523fe7896af89d@changeid>
Hi Archie,
> When receiving an L2CAP_CONFIGURATION_REQ with an unknown config
> type, currently we will reply with L2CAP_CONFIGURATION_RSP with
> a list of unknown types as the config param. However, this is not
> a correct format of config param.
>
> As described in the bluetooth spec v5.2, Vol 3, Part A, Sec 5,
> the config param should consists of type, length, and optionally
> data.
>
> This patch copies the length and data from the received
> L2CAP_CONFIGURATION_REQ and also appends them to the config param
> of the corresponding L2CAP_CONFIGURATION_RSP to match the format
> of the config param according to the spec.
any chance you could add btmon traces to the commit message to show the wrong behavior?
Regards
Marcel
prev parent reply other threads:[~2020-09-25 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 15:45 [PATCH v1] Bluetooth: send proper config param to unknown config request Archie Pusaka
2020-09-25 16:11 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83EE8429-0454-4348-9FDA-AC275C3D5B8E@holtmann.org \
--to=marcel@holtmann.org \
--cc=alainm@chromium.org \
--cc=apusaka@chromium.org \
--cc=apusaka@google.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).