From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF02EC3A589 for ; Fri, 23 Aug 2019 05:17:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C858A22CF7 for ; Fri, 23 Aug 2019 05:17:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391956AbfHWFRm (ORCPT ); Fri, 23 Aug 2019 01:17:42 -0400 Received: from mga17.intel.com ([192.55.52.151]:38604 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391807AbfHWFRm (ORCPT ); Fri, 23 Aug 2019 01:17:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2019 22:17:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,420,1559545200"; d="scan'208";a="186777188" Received: from pkacprow-mobl.ger.corp.intel.com ([10.252.30.96]) by FMSMGA003.fm.intel.com with ESMTP; 22 Aug 2019 22:17:40 -0700 Message-ID: <84a882c0bd2954c21735005534abb5568b2fc806.camel@intel.com> Subject: Re: [PATCH] iwlwifi: mvm: fix old-style declaration From: Luciano Coelho To: YueHaibing , johannes.berg@intel.com, emmanuel.grumbach@intel.com, linuxwifi@intel.com, kvalo@codeaurora.org, sara.sharon@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org Date: Fri, 23 Aug 2019 08:17:39 +0300 In-Reply-To: <20190726141838.19424-1-yuehaibing@huawei.com> References: <20190726141838.19424-1-yuehaibing@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2019-07-26 at 22:18 +0800, YueHaibing wrote: > There expect the 'static' keyword to come first in a > declaration, and we get a warning for this with "make W=1": > > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:427:1: warning: > 'static' is not at beginning of declaration [-Wold-style-declaration] > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:434:1: warning: > 'static' is not at beginning of declaration [-Wold-style-declaration] > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- Thanks! Johannes applied this in our internal tree a few weeks ago and it will reach the mainline following our usual upstreaming process. -- Cheers, Luca.