From: Roman Mashak <mrv@mojatatu.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com
Subject: Re: [PATCH iproute2 1/1] ip netns: use strtol() instead of atoi()
Date: Tue, 31 Oct 2017 14:01:32 -0400 [thread overview]
Message-ID: <85efpjfb7n.fsf@mojatatu.com> (raw)
In-Reply-To: <20171031173101.59e0047a@shemminger-XPS-13-9360> (Stephen Hemminger's message of "Tue, 31 Oct 2017 17:31:01 +0100")
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Fri, 27 Oct 2017 12:55:27 -0400
> Roman Mashak <mrv@mojatatu.com> wrote:
>
>> Use strtol-based API to parse and validate integer input; atoi() does not detect
>> errors and may yield undefined behaviour if result can't be represented.
>>
>> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
>
> Since network namespace is really an unsigned value, shouldn't it be
> using get_unsigned?
Agree, I will resend v2.
prev parent reply other threads:[~2017-10-31 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 16:55 [PATCH iproute2 1/1] ip netns: use strtol() instead of atoi() Roman Mashak
2017-10-31 16:31 ` Stephen Hemminger
2017-10-31 18:01 ` Roman Mashak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85efpjfb7n.fsf@mojatatu.com \
--to=mrv@mojatatu.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).