netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
To: "Richard Weinberger" <richard.weinberger@gmail.com>,
	Алексей <ne-vlezay80@yandex.ru>
Cc: netdev@vger.kernel.org, linux-um@lists.infradead.org
Subject: Re: [PATCH] User mode linux bump maximum MTU tuntap interface [RESAND]
Date: Tue, 2 Jul 2019 15:47:13 +0100	[thread overview]
Message-ID: <86215743-4340-7d54-6657-19546de2377a@kot-begemot.co.uk> (raw)
In-Reply-To: <CAFLxGvytDC1TFdT0m9vvijz_93B8TziWURcR-3mskWB-7TzFag@mail.gmail.com>



On 02/07/2019 15:40, Richard Weinberger wrote:
> CC'ing um folks.
> 
> On Tue, Jul 2, 2019 at 3:01 PM Алексей <ne-vlezay80@yandex.ru> wrote:
>>
>> Hello, the parameter  ETH_MAX_PACKET limited to 1500 bytes is the not
>> support jumbo frames.
>>
>> This patch change ETH_MAX_PACKET the 65535 bytes to jumbo frame support
>> with user mode linux tuntap driver.
>>
>>
>> PATCH:
>>
>> -------------------
>>
>>
>> diff -ruNP ../linux_orig/linux-5.1/arch/um/include/shared/net_user.h
>> ./arch/um/include/shared/net_user.h
>> --- a/arch/um/include/shared/net_user.h    2019-05-06 00:42:58.000000000
>> +0000
>> +++ b/arch/um/include/shared/net_user.h    2019-07-02 07:14:13.593333356
>> +0000
>> @@ -9,7 +9,7 @@
>>   #define ETH_ADDR_LEN (6)
>>   #define ETH_HEADER_ETHERTAP (16)
>>   #define ETH_HEADER_OTHER (26) /* 14 for ethernet + VLAN + MPLS for
>> crazy people */
>> -#define ETH_MAX_PACKET (1500)
>> +#define ETH_MAX_PACKET (65535)
>>
>>   #define UML_NET_VERSION (4)
>>
>> -------------------
>>
>>
> 
> 

The vector version for tap already allows mtu > 1500. It does not have a 
check to limit it to 65535 max though and it should.

I will add this one to the queue of stuff for the network drivers. IMHO 
we should start migrating some of the older ones to vector IO.

-- 
Anton R. Ivanov
https://www.kot-begemot.co.uk/

  reply	other threads:[~2019-07-02 15:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01 16:29 [PATCH] User mode linux bump maximum MTU tuntap interface Алексей
2019-07-02 12:55 ` [PATCH] User mode linux bump maximum MTU tuntap interface [RESAND] Алексей
2019-07-02 14:40   ` Richard Weinberger
2019-07-02 14:47     ` Anton Ivanov [this message]
2019-07-12  9:22     ` Anton Ivanov
2019-07-12  9:40       ` Anton Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86215743-4340-7d54-6657-19546de2377a@kot-begemot.co.uk \
    --to=anton.ivanov@kot-begemot.co.uk \
    --cc=linux-um@lists.infradead.org \
    --cc=ne-vlezay80@yandex.ru \
    --cc=netdev@vger.kernel.org \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).