From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B06A4C433DB for ; Mon, 8 Feb 2021 18:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AEE564E37 for ; Mon, 8 Feb 2021 18:32:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235476AbhBHScN (ORCPT ); Mon, 8 Feb 2021 13:32:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234021AbhBHSbw (ORCPT ); Mon, 8 Feb 2021 13:31:52 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30373C061786 for ; Mon, 8 Feb 2021 10:31:10 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id t142so76360wmt.1 for ; Mon, 08 Feb 2021 10:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Hs7wTewV0cufOq3PKa0WHvUyp9n739TnznjMarToqCc=; b=RpH2Lz7pBFJIErN3xdxHHdFPlTYVidTrYSQl2BdM18gPbVKsM17KVw8Wm8RX2E2XW2 AycEOG7v0fX26zn8907VQhL15f534mcTbbZGCureeKPd6Hll9jI7w3377pnOlOiD9fuU h+AfZ0LwIsl4uhEfrDJRnCQNGB4jKMHgk+3Shirh9RNs6Qu3vgRpRbPT9Ba3koI3dQ76 Dizy6QoxVDomW5LZ7lDk1yk+Ag6yp8JGjEULUE5RElSHF6VSTGfwLujuOV5eFqEPTn2b 9fWIxx0wU3fIeuVYl1B5Wdf6rQstvAFfx8Xq+hPv2KcrdgYDXPwWF4tfrpJ67JMEBTRS TvFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Hs7wTewV0cufOq3PKa0WHvUyp9n739TnznjMarToqCc=; b=pHFHtAT1mmyk4tpoEpTNzZu1xBjvfHTlWTTdS7ZfIFSaBd5udOYd8Pte4oBWJlkEMY OYztzELJNTJdYRCXZfahxENZVQPSY55nnmV3+0zaoYuaBKzUhsx3iqfDG7nHvwYFkmZv XqK17OsBowbfGsFMtwk0LZWDohNKm+ZN6mXN7NpBTMaN0XCIT+PYnsbkRkGKf8FBh4NX rOvn/lpTjBByHKuVcOoyPpQaJjfSff83xzlMRjhjI8ZdRwafpJc61ioAfpNvW0zfTzyI jjPgt2QzXpYUYBNK9QhvvSfeRzhPhWbie/99YHaglgPazinI1QD0CZQ86kRqsDv3sEgm Q5oQ== X-Gm-Message-State: AOAM530HfNfk3nahK/55xZg2bnF8DpnW8PjiwT8inytMcQolgmr7KZOz /oQM/FAegsevvi8gjT3Ckck= X-Google-Smtp-Source: ABdhPJwDkDr4OWzpD4EadcmAHIpfdVUqSpYecmRUS0lKqY3l3JR4RSI61qCyK3oygQYLf0zOoChAPQ== X-Received: by 2002:a05:600c:2f81:: with SMTP id t1mr100238wmn.186.1612809068975; Mon, 08 Feb 2021 10:31:08 -0800 (PST) Received: from [192.168.1.101] ([37.171.108.87]) by smtp.gmail.com with ESMTPSA id q24sm51964wmq.24.2021.02.08.10.31.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 10:31:08 -0800 (PST) Subject: Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros To: Taehee Yoo , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, dsahern@kernel.org, xiyou.wangcong@gmail.com References: <20210208175820.5690-1-ap420073@gmail.com> From: Eric Dumazet Message-ID: <8633a76b-84c1-44c1-f532-ce66c1502b5c@gmail.com> Date: Mon, 8 Feb 2021 19:31:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210208175820.5690-1-ap420073@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/8/21 6:58 PM, Taehee Yoo wrote: > Currently, struct ip6_sf_socklist doesn't use list API so that code > shape is a little bit different from others. > So it converts ip6_sf_socklist to use list API so it would > improve readability. > > Signed-off-by: Taehee Yoo > --- > include/net/if_inet6.h | 19 +- > include/uapi/linux/in.h | 4 +- > net/ipv6/mcast.c | 387 +++++++++++++++++++++++++--------------- > 3 files changed, 256 insertions(+), 154 deletions(-) > > diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h > index babf19c27b29..6885ab8ec2e9 100644 > --- a/include/net/if_inet6.h > +++ b/include/net/if_inet6.h > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > /* inet6_dev.if_flags */ > > @@ -76,23 +77,19 @@ struct inet6_ifaddr { > }; > > struct ip6_sf_socklist { > - unsigned int sl_max; > - unsigned int sl_count; > - struct in6_addr sl_addr[]; > + struct list_head list; > + struct in6_addr sl_addr; > + struct rcu_head rcu; > }; > I dunno about readability, but : Your patches adds/delete more than 1000 lines, who is really going to review this ? You replace dense arrays by lists, so the performance will likely be hurt, as cpu caches will be poorly used.