From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14BFC10F13 for ; Tue, 16 Apr 2019 21:54:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE5BC206B6 for ; Tue, 16 Apr 2019 21:54:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nj81oERB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730586AbfDPVyI (ORCPT ); Tue, 16 Apr 2019 17:54:08 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35966 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727845AbfDPVyI (ORCPT ); Tue, 16 Apr 2019 17:54:08 -0400 Received: by mail-wr1-f67.google.com with SMTP id y13so29167755wrd.3 for ; Tue, 16 Apr 2019 14:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=0kp2YDQ9/mvVKR48oUJUVkrbKZv91OzltHx7Xz3SfSs=; b=nj81oERBmEAQJHb2Jdym5Pr3YRihK3KIXoBmyDu6qyVIN4b6mhcUA0yCaycTzxagUS k3bSdLvoBdgBZlt6dur0z/LLqDOLvcie2P1YWODWNdnERgvfimHCjh6ENp6JZqjzoXlo oNqPMp5KdXh1Z8PMJ2DnX62qTBbFb1ttxXh7awW0gdVFS2XzE7XXvU51ODo7fnTB4UMW Exok1VjBNC8wPddVJpajXkzs3J8C2YnpR9wpOGrOMqejr6AEHCEg7AmXi1SCNwEQyFzP tjeRckaxk9TF2jrNg0soF4D5D+93znqewai8jaz0mUTRjKjqF1DwEBAUsU916MT28pFa PrHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=0kp2YDQ9/mvVKR48oUJUVkrbKZv91OzltHx7Xz3SfSs=; b=phl3QmyPyTgtNx6COed/TaImHDD7swKHZ+R1juFroC0u/ieBABQo7Wnnl1abNTZAuN DqTl60bzKA7tJp5nzGbnyEEujYL3pJGQ9XirA03RTg+sU7GkCb3AtDvkMNprxNolLycQ LqnabCD08YEqxC+VVSN6FRdbHTZQX/JwPytEOAJGjIhZPjHkbz9HBleMwVccCEURGUap I5kF91lR1YunFDvJ4UeEuzKwHfXoRaF3YWhXp9vrMmg4IL0A3UWsnfTCNb4zt6zN4OA3 VPUO2xuQnHQVH/mEXGAxQlmDn4AbZA2FYyVT0zYi2Xd6uASDN9Egm2cNNinuyY7EMSK2 kmkQ== X-Gm-Message-State: APjAAAXimM1giGnBWrIZfTmXnBP/cyoDf3xUFNqxmzKoMdaJYn5wkblW XtRlDdMFPSs0l8vwDHV90p+0f/lQ X-Google-Smtp-Source: APXvYqw7uX/sD7ZmDrKsfyaZs8QSUSkgXDnpzNnPMYG1+fudZfUWKDGKTbU6iA36MvBZYg8o+i2kPg== X-Received: by 2002:a5d:68cd:: with SMTP id p13mr18194431wrw.22.1555451646296; Tue, 16 Apr 2019 14:54:06 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:5700:6:2fe0:a59c:a230? (p200300EA8BD4570000062FE0A59CA230.dip0.t-ipconnect.de. [2003:ea:8bd4:5700:6:2fe0:a59c:a230]) by smtp.googlemail.com with ESMTPSA id h18sm66460921wrt.97.2019.04.16.14.54.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2019 14:54:05 -0700 (PDT) To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net-next] net: phy: don't set autoneg if it's not supported Message-ID: <86573735-5b70-4214-8acc-92763fc6e043@gmail.com> Date: Tue, 16 Apr 2019 23:54:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In phy_device_create() we set phydev->autoneg = 1. This isn't changed even if the PHY doesn't support autoneg. This seems to affect very few PHY's, and they disable phydev->autoneg in their config_init callback. So it's more of an improvement, therefore net-next. The patch also wouldn't apply to older kernel versions because the link mode bitmaps have been introduced recently. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 5eb905ab5..2d2b654e8 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2158,6 +2158,10 @@ static int phy_probe(struct device *dev) if (err) goto out; + if (!linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, + phydev->supported)) + phydev->autoneg = 0; + if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, phydev->supported)) phydev->is_gigabit_capable = 1; -- 2.21.0