netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: 曹煜 <cao88yu@gmail.com>, netdev <netdev@vger.kernel.org>,
	"Vivien Didelot" <vivien.didelot@gmail.com>
Subject: Re: [PATCH net] dsa: mv88e6xxx: 6161: Use chip wide MAX MTU
Date: Mon, 3 May 2021 02:38:14 +0000	[thread overview]
Message-ID: <86d42c49-27a7-734a-2ca8-b6e6ba826dc1@alliedtelesis.co.nz> (raw)
In-Reply-To: <YIwNzKZbiuLZRnoR@lunn.ch>


On 1/05/21 2:01 am, Andrew Lunn wrote:
> On Tue, Apr 27, 2021 at 01:34:41AM +0200, Andrew Lunn wrote:
>> The datasheets suggests the 6161 uses a per port setting for jumbo
>> frames. Testing has however shown this is not correct, it uses the old
>> style chip wide MTU control. Change the ops in the 6161 structure to
>> reflect this.
>>
>> Fixes: 1baf0fac10fb ("net: dsa: mv88e6xxx: Use chip-wide max frame size for MTU")
>> Reported by: 曹煜 <cao88yu@gmail.com>
>> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> self NACK.
>
> We dug deeper and found a different real problem. Patches to follow.

Hi Andrew,

I'm back on-line now. Anything I can help look at?

  reply	other threads:[~2021-05-03  2:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 23:34 [PATCH net] dsa: mv88e6xxx: 6161: Use chip wide MAX MTU Andrew Lunn
2021-04-26 23:36 ` Andrew Lunn
2021-04-27  0:18   ` 曹煜
2021-04-27  1:35     ` Andrew Lunn
2021-04-30 14:01 ` Andrew Lunn
2021-05-03  2:38   ` Chris Packham [this message]
2021-05-03 12:16     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86d42c49-27a7-734a-2ca8-b6e6ba826dc1@alliedtelesis.co.nz \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=andrew@lunn.ch \
    --cc=cao88yu@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).