From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: VLAN filtering with DSA
Date: Thu, 10 Sep 2020 11:42:02 -0700 [thread overview]
Message-ID: <86ebd9ca-86a3-0938-bf5d-9627420417bf@gmail.com> (raw)
In-Reply-To: <20200910150738.mwhh2i6j2qgacqev@skbuf>
On 9/10/2020 8:07 AM, Vladimir Oltean wrote:
> Hi,
>
> Problem background:
>
> Most DSA switch tags shift the EtherType to the right, causing the
> master to not parse the VLAN as VLAN.
> However, not all switches do that (example: tail tags), and if the DSA
> master has "rx-vlan-filter: on" in ethtool -k, then we have a problem.
> Therefore, I was thinking we could populate the VLAN table of the
> master, just in case, so that it can work with a VLAN filtering master.
> It would look something like this:
Yes, doing what you suggest would make perfect sense for a DSA master
that is capable of VLAN filtering, I did encounter that problem with
e1000 and the dsa-loop.c mockup driver while working on a mock-up 802.1Q
data path.
>
> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 19b98a7231ec..b8aca2301c59 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -307,9 +307,10 @@ static int dsa_slave_vlan_add(struct net_device *dev,
> const struct switchdev_obj *obj,
> struct switchdev_trans *trans)
> {
> + struct net_device *master = dsa_slave_to_master(dev);
> struct dsa_port *dp = dsa_slave_to_port(dev);
> struct switchdev_obj_port_vlan vlan;
> - int err;
> + int vid, err;
>
> if (obj->orig_dev != dev)
> return -EOPNOTSUPP;
> @@ -336,6 +337,12 @@ static int dsa_slave_vlan_add(struct net_device *dev,
> if (err)
> return err;
>
> + for (vid = vlan.vid_begin; vid <= vlan.vid_end; vid++) {
> + err = vlan_vid_add(master, htons(ETH_P_8021Q), vid);
> + if (err)
> + return err;
> + }
> +
> return 0;
> }
>
> @@ -379,8 +386,10 @@ static int dsa_slave_port_obj_add(struct net_device *dev,
> static int dsa_slave_vlan_del(struct net_device *dev,
> const struct switchdev_obj *obj)
> {
> + struct net_device *master = dsa_slave_to_master(dev);
> struct dsa_port *dp = dsa_slave_to_port(dev);
> struct switchdev_obj_port_vlan *vlan;
> + int vid, err;
>
> if (obj->orig_dev != dev)
> return -EOPNOTSUPP;
> @@ -396,7 +405,14 @@ static int dsa_slave_vlan_del(struct net_device *dev,
> /* Do not deprogram the CPU port as it may be shared with other user
> * ports which can be members of this VLAN as well.
> */
> - return dsa_port_vlan_del(dp, vlan);
> + err = dsa_port_vlan_del(dp, vlan);
> + if (err)
> + return err;
> +
> + for (vid = vlan->vid_begin; vid <= vlan->vid_end; vid++)
> + vlan_vid_del(master, htons(ETH_P_8021Q), vid);
> +
> + return 0;
> }
>
> static int dsa_slave_port_obj_del(struct net_device *dev,
> @@ -1241,6 +1257,7 @@ static int dsa_slave_get_ts_info(struct net_device *dev,
> static int dsa_slave_vlan_rx_add_vid(struct net_device *dev, __be16 proto,
> u16 vid)
> {
> + struct net_device *master = dsa_slave_to_master(dev);
> struct dsa_port *dp = dsa_slave_to_port(dev);
> struct switchdev_obj_port_vlan vlan = {
> .obj.id = SWITCHDEV_OBJ_ID_PORT_VLAN,
> @@ -1294,12 +1311,13 @@ static int dsa_slave_vlan_rx_add_vid(struct net_device *dev, __be16 proto,
> if (ret)
> return ret;
>
> - return 0;
> + return vlan_vid_add(master, proto, vid);
> }
>
> static int dsa_slave_vlan_rx_kill_vid(struct net_device *dev, __be16 proto,
> u16 vid)
> {
> + struct net_device *master = dsa_slave_to_master(dev);
> struct dsa_port *dp = dsa_slave_to_port(dev);
> struct switchdev_obj_port_vlan vlan = {
> .vid_begin = vid,
> @@ -1332,7 +1350,13 @@ static int dsa_slave_vlan_rx_kill_vid(struct net_device *dev, __be16 proto,
> /* Do not deprogram the CPU port as it may be shared with other user
> * ports which can be members of this VLAN as well.
> */
> - return dsa_port_vlan_del(dp, &vlan);
> + ret = dsa_port_vlan_del(dp, &vlan);
> + if (ret)
> + return ret;
> +
> + vlan_vid_del(master, proto, vid);
> +
> + return 0;
> }
>
> struct dsa_hw_port {
>
--
Florian
next prev parent reply other threads:[~2020-09-10 18:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 15:07 VLAN filtering with DSA Vladimir Oltean
2020-09-10 18:41 ` Florian Fainelli
2020-09-11 13:20 ` Ido Schimmel
2020-09-11 16:30 ` Vladimir Oltean
2020-09-11 16:32 ` Vladimir Oltean
2020-09-11 16:57 ` Florian Fainelli
2020-09-10 18:42 ` Florian Fainelli [this message]
2020-09-10 19:01 ` Vladimir Oltean
2020-09-10 19:05 ` Florian Fainelli
2020-09-10 19:08 ` Vladimir Oltean
2020-09-10 19:09 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ebd9ca-86a3-0938-bf5d-9627420417bf@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).