* [PATCH] net: skbuff.h: drop unneeded <linux/slab.h>
@ 2018-06-03 4:40 Randy Dunlap
2018-06-04 21:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-06-03 4:40 UTC (permalink / raw)
To: netdev, David Miller; +Cc: LKML, Andrew Morton
From: Randy Dunlap <rdunlap@infradead.org>
<linux/skbuff.h> does not use nor need <linux/slab.h>, so drop this
header file from skbuff.h.
<linux/skbuff.h> is currently #included in around 1200 C source and
header files, making it the 31st most-used header file.
Build tested [allmodconfig] on 20 arch-es.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
include/linux/skbuff.h | 2 --
1 file changed, 2 deletions(-)
--- lnx.orig/include/linux/skbuff.h
+++ lnx.next/include/linux/skbuff.h
@@ -852,8 +852,6 @@ struct sk_buff {
/*
* Handling routines are only of interest to the kernel
*/
-#include <linux/slab.h>
-
#define SKB_ALLOC_FCLONE 0x01
#define SKB_ALLOC_RX 0x02
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: skbuff.h: drop unneeded <linux/slab.h>
2018-06-03 4:40 [PATCH] net: skbuff.h: drop unneeded <linux/slab.h> Randy Dunlap
@ 2018-06-04 21:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-06-04 21:02 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, linux-kernel, akpm
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sat, 2 Jun 2018 21:40:19 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> <linux/skbuff.h> does not use nor need <linux/slab.h>, so drop this
> header file from skbuff.h.
>
> <linux/skbuff.h> is currently #included in around 1200 C source and
> header files, making it the 31st most-used header file.
>
> Build tested [allmodconfig] on 20 arch-es.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thanks Randy.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-04 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-03 4:40 [PATCH] net: skbuff.h: drop unneeded <linux/slab.h> Randy Dunlap
2018-06-04 21:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).