From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FEFC433FE for ; Mon, 27 Sep 2021 14:02:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5819D60F46 for ; Mon, 27 Sep 2021 14:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234811AbhI0ODj (ORCPT ); Mon, 27 Sep 2021 10:03:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234970AbhI0ODe (ORCPT ); Mon, 27 Sep 2021 10:03:34 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69854C061782 for ; Mon, 27 Sep 2021 07:01:24 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id u18so76520932lfd.12 for ; Mon, 27 Sep 2021 07:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=s9j0LgQC+YVJViqWRdjpPa26B5KzaV4iAKUPDeJDa7M=; b=fzL0q7aexhqMCVNkHA17E7KdXD6r5ZARfBPIXA4DYqjT6IQ4dVqeD1JNs+FlGCpwI7 g1E7fPed0+u35YE5OEYz2s1x0pXzoDZ1KWkhwEz/zyQNsP1ckGj1owsJcELaPQTLAEnV wzXHFK2bClY/3RFvaOqElw1PLAZfRvNTaWFi8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=s9j0LgQC+YVJViqWRdjpPa26B5KzaV4iAKUPDeJDa7M=; b=VAoO/NzjXSIddLW9vGG5x8JugtjGTTfp0j1NltWjeVUfrVE4xooycUpBkC4syzpQvE YqDy+1zmjPANdScLtFpBiEcOXvk+5mQAll+SSLHcsC35fsZEfkSPgEKzItyuJkgLWE93 dCNJs/pUCBuHAhCTtmEW8Ne9sDZqPR3N84ND1THJ08jV3XEHxaMqcm3t7JYlW/HsJ6Wg a5NLUCFr5g9wAjPont7RcZrQ6drRaeCPDKxT+bcjfHXTtyugZIVeUF4qZpP472vUTkrQ oMQOMei6r6oLnjXtphKAdZS7WxmOcNAxzJf1M3x1V9OJZ8MAF+UlNKJZSWhGEcso9FJI 6krg== X-Gm-Message-State: AOAM532ZwG5uu13wVuuG78fMadrWnEdnbCtJbO7ns8GwMsc/iqvszK9g FQ7romBqUphLzno/9QE94p1vRw== X-Google-Smtp-Source: ABdhPJwMx0WJg6o5/zvf8pCndWw5tsEjVtVB+Sej46yznRBrg+antKzEtDG47vGlQmjM2NVVMsgSig== X-Received: by 2002:a05:6512:23a1:: with SMTP id c33mr4668734lfv.518.1632751280890; Mon, 27 Sep 2021 07:01:20 -0700 (PDT) Received: from cloudflare.com (2a01-110f-480d-6f00-ff34-bf12-0ef2-5071.aa.ipv6.supernova.orange.pl. [2a01:110f:480d:6f00:ff34:bf12:ef2:5071]) by smtp.gmail.com with ESMTPSA id j26sm1605501lfk.287.2021.09.27.07.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 07:01:20 -0700 (PDT) References: <20210924095542.33697-1-lmb@cloudflare.com> <20210924095542.33697-5-lmb@cloudflare.com> User-agent: mu4e 1.1.0; emacs 27.2 From: Jakub Sitnicki To: Daniel Borkmann Cc: Lorenz Bauer , Alexei Starovoitov , Andrii Nakryiko , "David S. Miller" , Jakub Kicinski , kernel-team@cloudflare.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next 4/4] bpf: export bpf_jit_current In-reply-to: Date: Mon, 27 Sep 2021 16:01:18 +0200 Message-ID: <871r5aglsh.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Sep 27, 2021 at 03:34 PM CEST, Daniel Borkmann wrote: > On 9/24/21 11:55 AM, Lorenz Bauer wrote: >> Expose bpf_jit_current as a read only value via sysctl. >> Signed-off-by: Lorenz Bauer >> --- I find exposing stats via system configuration variables a bit unexpected. Not sure if there is any example today that we're following. Maybe an entry under /sys/kernel/debug would be a better fit? That way we don't have to commit to a sysctl that might go away if we start charging JIT allocs against memory cgroup quota. Although that brings up question against which cgroup iptables xt_bpf allocations should be charged? Root cgroup?