From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: Vineet Gupta <vgupta@synopsys.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
<linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Brett Rudley <brudley@broadcom.com>,
"Franky \(Zhenhui\) Lin" <frankyl@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
Pieter-Paul Giesberts <pieterpg@broadcom.com>,
Daniel Kim <dekim@broadcom.com>, <linux-wireless@vger.kernel.org>,
<brcm80211-dev-list@broadcom.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive
Date: Mon, 27 Jul 2015 13:08:43 +0300 [thread overview]
Message-ID: <871tftc3pw.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <55B4C0A8.9000909@broadcom.com> (Arend van Spriel's message of "Sun, 26 Jul 2015 13:12:40 +0200")
Arend van Spriel <arend@broadcom.com> writes:
> On 07/24/2015 07:22 PM, Vineet Gupta wrote:
>> On Friday 24 July 2015 08:02 PM, Kalle Valo wrote:
>>> Vineet Gupta <Vineet.Gupta1@synopsys.com> writes:
>>>
>>>>> There's already a generic implementation so use that instead.
>>>>> ---
>>>>> I'm not sure if the driver usage of atomic_or?() is correct in terms of
>>>>> storage size of @val for 64 bit arches.
>>>>>
>>>>> Assuming LP64 programming model for linux on say x86_64: atomic_or()
>>>>> callers in this driver use long (sana 64 bit) storage and pass it to
>>>>> atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ?
>>>>> ---
>>>>> Cc: Brett Rudley <brudley@broadcom.com>
>>>>> Cc: Arend van Spriel <arend@broadcom.com>
>>>>> Cc: "Franky (Zhenhui) Lin" <frankyl@broadcom.com>
>>>>> Cc: Hante Meuleman <meuleman@broadcom.com>
>>>>> Cc: Kalle Valo <kvalo@codeaurora.org>
>>>>> Cc: Pieter-Paul Giesberts <pieterpg@broadcom.com>
>>>>> Cc: Daniel Kim <dekim@broadcom.com>
>>>>> Cc: linux-wireless@vger.kernel.org
>>>>> Cc: brcm80211-dev-list@broadcom.com
>>>>> Cc: Peter Zijlstra <peterz@infradead.org>
>>>>> Cc: Ingo Molnar <mingo@kernel.org>
>>>>> Cc: netdev@vger.kernel.org
>>>>> Cc: linux-arch@vger.kernel.org
>>>>> Cc: linux-kernel@vger.kernel.org
>>>>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>>>>>
>>>>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>>> What's the plan with this patch? Should I take it to my
>>> wireless-drivers-next tree or will someone else take it?
>>
>>
>> Per last discussion on this topic, Arend wanted to discuss abt this with Hante.
>> I'm not taking it anyways so feel free to pick it up if you want !
>
> Well, that was before your "timeline" clarification about the generic
> function. One what tree is this patch based?
Yeah, if this patch depends on another patch I need to know about it.
Otherwise I might break something when I apply this patch.
--
Kalle Valo
next prev parent reply other threads:[~2015-07-27 10:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1436429599-10762-1-git-send-email-vgupta@synopsys.com>
2015-07-09 8:13 ` [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive Vineet Gupta
2015-07-09 18:25 ` Arend van Spriel
2015-07-09 18:31 ` Arend van Spriel
2015-07-09 19:57 ` Peter Zijlstra
2015-07-10 4:49 ` Vineet Gupta
2015-07-10 9:05 ` Arend van Spriel
2015-07-24 17:02 ` Kalle Valo
2015-07-24 17:22 ` Vineet Gupta
2015-07-26 11:12 ` Arend van Spriel
2015-07-27 10:08 ` Kalle Valo [this message]
2015-07-27 10:23 ` Vineet Gupta
2015-08-13 12:30 ` [2/3] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tftc3pw.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Vineet.Gupta1@synopsys.com \
--cc=arend@broadcom.com \
--cc=arnd@arndb.de \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=dekim@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pieterpg@broadcom.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).