From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>, stephen@networkplumber.org
Cc: wangxiongfeng2@huawei.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net-sysfs: add a newline when printing 'tx_timeout' by sysfs
Date: Wed, 22 Jul 2020 13:46:32 -0700 [thread overview]
Message-ID: <8721f64a3150e1e5c4813738f470443297ef1cdd.camel@perches.com> (raw)
In-Reply-To: <20200722.132311.31388808811810422.davem@davemloft.net>
On Wed, 2020-07-22 at 13:23 -0700, David Miller wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Wed, 22 Jul 2020 08:27:41 -0700
>
> > On Tue, 21 Jul 2020 15:36:32 -0700 (PDT)
> > David Miller <davem@davemloft.net> wrote:
> >
> >> From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> >> Date: Tue, 21 Jul 2020 15:02:57 +0800
> >>
> >> > When I cat 'tx_timeout' by sysfs, it displays as follows. It's better to
> >> > add a newline for easy reading.
> >> >
> >> > root@syzkaller:~# cat /sys/devices/virtual/net/lo/queues/tx-0/tx_timeout
> >> > 0root@syzkaller:~#
> >> >
> >> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> >>
> >> Applied, thank you.
> >
> > Could you add
>
> Stephen, of all people you should know by now that all of my commits
> are %100 immutable. So commit log changes cannot be made after I've
> applied the patch, ever.
Maybe it's time to use git notes?
next prev parent reply other threads:[~2020-07-22 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 7:02 [PATCH v2] net-sysfs: add a newline when printing 'tx_timeout' by sysfs Xiongfeng Wang
2020-07-21 22:36 ` David Miller
2020-07-22 15:27 ` Stephen Hemminger
2020-07-22 20:23 ` David Miller
2020-07-22 20:46 ` Joe Perches [this message]
2020-07-22 21:27 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8721f64a3150e1e5c4813738f470443297ef1cdd.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).