From: Kalle Valo <kvalo@codeaurora.org>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Solomon Peachy <pizza@shaftnet.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 17/35] net/wireless: Use kmemdup rather than duplicating its implementation
Date: Mon, 15 Jul 2019 12:33:39 +0300 [thread overview]
Message-ID: <874l3nr6a4.fsf@codeaurora.org> (raw)
In-Reply-To: <20190703162934.32645-1-huangfq.daxian@gmail.com> (Fuqian Huang's message of "Thu, 4 Jul 2019 00:29:34 +0800")
Fuqian Huang <huangfq.daxian@gmail.com> writes:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
I'm planning to take this.
--
Kalle Valo
next prev parent reply other threads:[~2019-07-15 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 16:29 [PATCH v2 17/35] net/wireless: Use kmemdup rather than duplicating its implementation Fuqian Huang
2019-07-15 9:33 ` Kalle Valo [this message]
2019-10-02 4:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l3nr6a4.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=huangfq.daxian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pizza@shaftnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).