From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v5 5/5] selftests: Add tests for automatic map pinning
Date: Sat, 02 Nov 2019 11:56:56 +0100 [thread overview]
Message-ID: <875zk2mtqf.fsf@toke.dk> (raw)
In-Reply-To: <CAEf4BzYWgnek1QYyQm4U0qakP=Si0vEJ2bLKHeJhambyX7EnCQ@mail.gmail.com>
Andrii Nakryiko <andrii.nakryiko@gmail.com> writes:
> On Fri, Nov 1, 2019 at 2:53 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>>
>> From: Toke Høiland-Jørgensen <toke@redhat.com>
>>
>> This adds a new BPF selftest to exercise the new automatic map pinning
>> code.
>>
>> Acked-by: Andrii Nakryiko <andriin@fb.com>
>
> I don't believe I acked this patch before, must have been added by
> mistake.
No you didn't, sorry about that; I was adding in your ACKs to the other
patches and must have added this one as well by mistake.
> But either way thanks for improving tests and testing a good variety
> of scenarios, I appreciate the work. Please fix bpf_object leak below
> and keep my Acked-by :)
Will do, thanks!
-Toke
prev parent reply other threads:[~2019-11-02 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 9:52 [PATCH bpf-next v5 0/5] libbpf: Support automatic pinning of maps using 'pinning' BTF attribute Toke Høiland-Jørgensen
2019-11-01 9:52 ` [PATCH bpf-next v5 1/5] libbpf: Fix error handling in bpf_map__reuse_fd() Toke Høiland-Jørgensen
2019-11-01 9:52 ` [PATCH bpf-next v5 2/5] libbpf: Store map pin path and status in struct bpf_map Toke Høiland-Jørgensen
2019-11-02 5:10 ` Andrii Nakryiko
2019-11-02 10:57 ` Toke Høiland-Jørgensen
2019-11-01 9:52 ` [PATCH bpf-next v5 3/5] libbpf: Move directory creation into _pin() functions Toke Høiland-Jørgensen
2019-11-01 9:53 ` [PATCH bpf-next v5 4/5] libbpf: Add auto-pinning of maps when loading BPF objects Toke Høiland-Jørgensen
2019-11-01 9:53 ` [PATCH bpf-next v5 5/5] selftests: Add tests for automatic map pinning Toke Høiland-Jørgensen
2019-11-02 5:07 ` Andrii Nakryiko
2019-11-02 10:56 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zk2mtqf.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).