From: "Toke Høiland-Jørgensen" <thoiland@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
David Miller <davem@davemloft.net>,
Greg KH <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH RFC net-next] net: WireGuard secure network tunnel
Date: Thu, 21 Nov 2019 11:29:16 +0100 [thread overview]
Message-ID: <877e3t8qv7.fsf@toke.dk> (raw)
In-Reply-To: <20191120203538.199367-1-Jason@zx2c4.com>
"Jason A. Donenfeld" <Jason@zx2c4.com> writes:
> RFC Note:
> This is a RFC for folks who want to play with this early, because
> Herbert's cryptodev-2.6 tree hasn't yet made it into net-next. I'll
> repost this as a v1 (possibly with feedback incorporated) once the
> various trees are in the right place. This compiles on top of the
> Frankenzinc patchset from Ard, though it hasn't yet received suitable
> testing there for me to call it v1 just yet. Preliminary testing with
> the usual netns.sh test suite on x86 indicates it's at least mostly
> functional, but I'll be giving things further scrutiny in the days to
> come.
Hi Jason
Great to see this! Just a few small comments for now:
> +/*
> + * Copyright (C) 2015-2019 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
> + */
Could you please get rid of the "All Rights Reserved" (here, and
everywhere else)? All rights are *not* reserved: this is licensed under
the GPL. Besides, that phrase is in general dubious at best:
https://en.wikipedia.org/wiki/All_rights_reserved
> + MAX_QUEUED_INCOMING_HANDSHAKES = 4096, /* TODO: replace this with DQL */
> + MAX_STAGED_PACKETS = 128,
> + MAX_QUEUED_PACKETS = 1024 /* TODO: replace this with DQL */
Yes, please (on the TODO) :)
FWIW, since you're using pointer rings I think the way to do this is
probably to just keep the limits in place as a maximum size, and then
use DQL (or CoDel) to throttle enqueue to those pointer rings instead of
just letting them fill.
Happy to work with you on this (as I believe I've already promised), but
we might as well do that after the initial version is merged...
-Toke
next prev parent reply other threads:[~2019-11-21 10:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 20:35 [PATCH RFC net-next] net: WireGuard secure network tunnel Jason A. Donenfeld
2019-11-21 10:29 ` Toke Høiland-Jørgensen [this message]
2019-11-21 11:07 ` Jason A. Donenfeld
2019-11-21 12:00 ` Toke Høiland-Jørgensen
2019-11-21 14:44 ` Miguel Ojeda
2019-11-21 15:26 ` Jason A. Donenfeld
2019-11-21 11:50 ` Greg KH
2019-11-27 10:49 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e3t8qv7.fsf@toke.dk \
--to=thoiland@redhat.com \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).