From: Kalle Valo <kvalo@codeaurora.org>
To: torvalds@linux-foundation.org, Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, davem@davemloft.net,
emmanuel.grumbach@intel.com,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it
Date: Thu, 07 Sep 2017 15:39:05 +0300 [thread overview]
Message-ID: <877exan0nq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170907075152.4522-1-luca@coelho.fi> (Luca Coelho's message of "Thu, 7 Sep 2017 10:51:52 +0300")
Luca Coelho <luca@coelho.fi> writes:
> From: Luca Coelho <luciano.coelho@intel.com>
>
> The LEDS_CMD command is only supported in some newer FW versions
> (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions
> (such as iwlwifi-8000C-27.ucode).
>
> To fix this, check for a new bit in the FW capabilities TLV that tells
> when the command is supported.
>
> Note that the current version of -31.ucode in linux-firmware.git
> (31.532993.0) does not have this capability bit set, so the LED won't
> work, even though this version should support it. But we will update
> this firmware soon, so it won't be a problem anymore.
>
> Fixes: 7089ae634c50 ("iwlwifi: mvm: use firmware LED command where applicable")
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Linus, do you want to apply this directly or should we take it via the
normal route (wireless-drivers -> net)? If your prefer the latter when
I'm planning to submit this to Dave in a day or two and expecting it to
get to your tree in about a week, depending of course what is Dave's
schedule.
--
Kalle Valo
next prev parent reply other threads:[~2017-09-07 12:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 4:41 [GIT] Networking David Miller
2017-09-06 23:27 ` Linus Torvalds
2017-09-06 23:31 ` David Miller
2017-09-06 23:37 ` Linus Torvalds
2017-09-07 4:11 ` Coelho, Luciano
2017-09-07 4:57 ` Linus Torvalds
2017-09-07 5:04 ` Coelho, Luciano
2017-09-07 5:40 ` Luca Coelho
2017-09-07 5:46 ` Linus Torvalds
2017-09-07 7:51 ` [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it Luca Coelho
2017-09-07 12:39 ` Kalle Valo [this message]
[not found] ` <877exan0nq.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2017-09-07 16:13 ` Linus Torvalds
2017-09-07 16:36 ` Kalle Valo
2017-09-07 16:40 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877exan0nq.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).