From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02AAFC433E0 for ; Sat, 16 Jan 2021 12:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5093230FE for ; Sat, 16 Jan 2021 12:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbhAPMXe (ORCPT ); Sat, 16 Jan 2021 07:23:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbhAPMXc (ORCPT ); Sat, 16 Jan 2021 07:23:32 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22825C061757 for ; Sat, 16 Jan 2021 04:22:52 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id u25so17218177lfc.2 for ; Sat, 16 Jan 2021 04:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=waldekranz-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=VZQgXJ3sozKQS+EOLjQhPRf8+tiITg33CWg9Ya6+elE=; b=U15IpH/80IkVMuRVSTT+D0VqtAzhnCWcvJAoz99h0HDGz1vGpfRdtbEYL6h314gFpA qnELWLtY7TZTqwHHB62CCnDscY/7nJ/e6V5uFYWEMZ0oazQrhXBmZNOV+OpCkNyjOhdf myUMlzmpmPxEQ/LrASWVx4mTLlSvdL41zNRWQ0Ymxm6T/Nl8FBtMsGrFad3dyJWT1oV3 ApSIx00WDfK1lYw1/5R3nooLT/X1jtVtNES+yccSBl3tWbhEKmmodnbi9PDWGetSsJCz LIsSSKq10FBFxy9G/eqLqlY+C2mQ5ooMANxTLs0xkH5hm0fNt9guDE6noTcfcezmsDw0 E2cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=VZQgXJ3sozKQS+EOLjQhPRf8+tiITg33CWg9Ya6+elE=; b=mtmlIFR3vsvl3H1ywAEt2XINd7uD6gtzZXpJ1JjOByam/9moIYzpem1MfIR08piA0+ /dxUogph8N+YjeuSRzDMX886ihC3MluPOz1qGymTrTb23dRJD3rsyVq03FVz/tB6xbft psV8hy3rvrR54Vs92g/cj1VAy+NdA2uPPQlBcJcu4IjNwvT5BVfk5X4zfbSoQwiaLTyc SA1CLanSYLlabDrHz/l2UVE/c4Om8eAY9dbZVdAASseiiLtEdTEkGNj0jXcVhSwZ9Ohs CDEp7gOuXdEev5BffZsDohRyPlPDbcrQdVymVVThNglpWQ7R7eEm+oe1/0ywTE3GCWkE 79VQ== X-Gm-Message-State: AOAM531ggcXodikNFHvaWR2ianoHzNkeD0WiyGTgQRNsypHyEq8ZgT9A 9316TX/k/AXMJX/Fx6d+YEHEXA== X-Google-Smtp-Source: ABdhPJwv8yd2BfxvPK6uYIqrG/oujdKSdPPU+zoPhi+sLcdwy9JZFT/bcOkxu3d9QE+YTmHKCTL7gg== X-Received: by 2002:a19:3806:: with SMTP id f6mr8206820lfa.242.1610799770651; Sat, 16 Jan 2021 04:22:50 -0800 (PST) Received: from wkz-x280 (h-236-82.A259.priv.bahnhof.se. [98.128.236.82]) by smtp.gmail.com with ESMTPSA id n20sm1252416lfh.133.2021.01.16.04.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jan 2021 04:22:50 -0800 (PST) From: Tobias Waldekranz To: Rasmus Villemoes , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski Cc: Rasmus Villemoes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: use mv88e6185_g1_vtu_getnext() for the 6250 In-Reply-To: <20210116023937.6225-3-rasmus.villemoes@prevas.dk> References: <20210116023937.6225-1-rasmus.villemoes@prevas.dk> <20210116023937.6225-3-rasmus.villemoes@prevas.dk> Date: Sat, 16 Jan 2021 13:22:49 +0100 Message-ID: <878s8tkr52.fsf@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jan 16, 2021 at 03:39, Rasmus Villemoes wrote: > mv88e6250_g1_vtu_getnext is almost identical to > mv88e6185_g1_vtu_getnext, except for the 6250 only having 64 databases > instead of 256. We can reduce code duplication by simply masking off > the extra two garbage bits when assembling the fid from VTU op [3:0] > and [11:8]. > > Signed-off-by: Rasmus Villemoes We might also want to give mv88e6250_g1_vtu_loadpurge the same treatment. Reviewed-by: Tobias Waldekranz Tested-by: Tobias Waldekranz