netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
	Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Subject: Re: [PATCH net-next 01/19] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE
Date: Tue, 09 Oct 2018 15:37:47 +0200	[thread overview]
Message-ID: <878t379r6c.fsf@miraculix.mork.no> (raw)
In-Reply-To: <d7ac7ff4c2fc479021286d0f7549d9b2e0aac803.1538734658.git.igor.russkikh@aquantia.com> (Igor Russkikh's message of "Fri, 5 Oct 2018 10:24:39 +0000")

Igor Russkikh <Igor.Russkikh@aquantia.com> writes:

>> +static const struct driver_info aqc111_info = {
> +	.description	= "Aquantia AQtion USB to 5GbE Controller",
> +};
> +
> +#define AQC111_USB_ETH_DEV(vid, pid, table) \
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE | \
> +			USB_DEVICE_ID_MATCH_INT_CLASS, \
> +	USB_DEVICE(vid, pid), \
> +	.bInterfaceClass = USB_CLASS_VENDOR_SPEC, \
> +	.driver_info = (unsigned long)&table, \
> +}, \
> +{ \
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE | \
> +			USB_DEVICE_ID_MATCH_INT_INFO, \
> +	USB_DEVICE(vid, pid), \
> +	.bInterfaceClass = USB_CLASS_COMM, \
> +	.bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
> +	.bInterfaceProtocol = USB_CDC_PROTO_NONE
> +

Is the missing .driver_info for the CDC class intentional?  If so, then
why include it at all?



Bjørn

  reply	other threads:[~2018-10-09 20:54 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 10:24 [PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices Igor Russkikh
2018-10-05 10:24 ` [PATCH net-next 01/19] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE Igor Russkikh
2018-10-09 13:37   ` Bjørn Mork [this message]
2018-10-05 10:24 ` [PATCH net-next 02/19] net: usb: aqc111: Add bind and empty unbind callbacks Igor Russkikh
2018-10-05 17:39   ` David Miller
2018-10-05 10:24 ` [PATCH net-next 03/19] net: usb: aqc111: Add implementation of read and write commands Igor Russkikh
2018-10-05 17:40   ` David Miller
2018-10-08 13:44   ` Oliver Neukum
2018-10-09 13:33   ` Bjørn Mork
2018-10-05 10:24 ` [PATCH net-next 04/19] net: usb: aqc111: Various callbacks implementation Igor Russkikh
2018-10-08 13:47   ` Oliver Neukum
2018-10-09 13:27     ` Bjørn Mork
2018-10-10 11:33       ` Oliver Neukum
2018-10-05 10:24 ` [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access Igor Russkikh
2018-10-05 22:04   ` Andrew Lunn
2018-10-08  9:09     ` Igor Russkikh
2018-10-08 12:17       ` Andrew Lunn
2018-10-08 14:07         ` Igor Russkikh
2018-10-10  0:58       ` Andrew Lunn
2018-10-10  7:54         ` Igor Russkikh
2018-10-08 13:52   ` Oliver Neukum
2018-10-08 14:10     ` Igor Russkikh
2018-10-08 14:24       ` Oliver Neukum
2018-10-05 10:24 ` [PATCH net-next 06/19] net: usb: aqc111: Introduce link management Igor Russkikh
2018-10-05 17:11   ` Andrew Lunn
2018-10-08 13:22     ` Igor Russkikh
2018-10-05 17:46   ` David Miller
2018-10-06 17:35   ` Andrew Lunn
2018-10-08  9:29     ` Igor Russkikh
2018-10-08 12:12       ` Andrew Lunn
2018-10-08 13:59   ` Oliver Neukum
2018-10-05 10:24 ` [PATCH net-next 07/19] net: usb: aqc111: Add support for getting and setting of MAC address Igor Russkikh
2018-10-06  1:03   ` Andrew Lunn
2018-10-09 14:34     ` Igor Russkikh
2018-10-09 14:46       ` Andrew Lunn
2018-10-05 10:25 ` [PATCH net-next 08/19] net: usb: aqc111: Implement TX data path Igor Russkikh
2018-10-06  1:13   ` Andrew Lunn
2018-10-08 13:43     ` Igor Russkikh
2018-10-08 14:07       ` Oliver Neukum
2018-10-09 13:50   ` Bjørn Mork
2018-10-05 10:25 ` [PATCH net-next 09/19] net: usb: aqc111: Implement RX " Igor Russkikh
2018-10-06  1:18   ` Andrew Lunn
2018-10-09 13:39   ` Bjørn Mork
2018-10-05 10:25 ` [PATCH net-next 10/19] net: usb: aqc111: Add checksum offload support Igor Russkikh
2018-10-05 10:25 ` [PATCH net-next 11/19] net: usb: aqc111: Add support for changing MTU Igor Russkikh
2018-10-06 16:56   ` Andrew Lunn
2018-10-05 10:25 ` [PATCH net-next 12/19] net: usb: aqc111: Add support for enable/disable checksum offload Igor Russkikh
2018-10-05 10:25 ` [PATCH net-next 13/19] net: usb: aqc111: Add support for TSO Igor Russkikh
2018-10-08 14:12   ` Oliver Neukum
2018-10-05 10:25 ` [PATCH net-next 14/19] net: usb: aqc111: Implement set_rx_mode callback Igor Russkikh
2018-10-06 17:03   ` Andrew Lunn
2018-10-08 13:49     ` Igor Russkikh
2018-10-05 10:25 ` [PATCH net-next 15/19] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload Igor Russkikh
2018-10-08 14:14   ` Oliver Neukum
2018-10-05 10:25 ` [PATCH net-next 16/19] net: usb: aqc111: Add RX VLAN filtering support Igor Russkikh
2018-10-06 17:05   ` Andrew Lunn
2018-10-05 10:25 ` [PATCH net-next 17/19] net: usb: aqc111: Initialize ethtool_ops structure Igor Russkikh
2018-10-06 17:08   ` Andrew Lunn
2018-10-05 10:25 ` [PATCH net-next 18/19] net: usb: aqc111: Implement get/set_link_ksettings callbacks Igor Russkikh
2018-10-06 17:38   ` Andrew Lunn
2018-10-08 14:18   ` Oliver Neukum
2018-10-05 10:25 ` [PATCH net-next 19/19] net: usb: aqc111: Add support for wake on LAN by MAGIC packet Igor Russkikh
2018-10-06 17:49   ` Andrew Lunn
2018-10-08 14:12     ` Igor Russkikh
2018-10-08 14:47       ` Andrew Lunn
2018-10-06 17:51 ` [PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices Andrew Lunn
2018-10-08  7:58   ` Igor Russkikh
2018-10-08 14:21 ` Oliver Neukum
2018-10-08 14:52   ` Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878t379r6c.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=Dmitry.Bezrukov@aquantia.com \
    --cc=Igor.Russkikh@aquantia.com \
    --cc=davem@davemloft.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).