From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH] net: sh_irda: fixup build error on v3.1 Date: Thu, 11 Aug 2011 02:02:07 -0700 (PDT) Message-ID: <878vr0wcc4.wl%kuninori.morimoto.gx@renesas.com> References: <87aabgwl9y.wl%kuninori.morimoto.gx@renesas.com> <20110810.231558.2202030270747790994.davem@davemloft.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from mail-iy0-f170.google.com ([209.85.210.170]:41048 "EHLO mail-iy0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753279Ab1HKJCI (ORCPT ); Thu, 11 Aug 2011 05:02:08 -0400 Received: by iye16 with SMTP id 16so911257iye.1 for ; Thu, 11 Aug 2011 02:02:07 -0700 (PDT) In-Reply-To: <20110810.231558.2202030270747790994.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hi David Thank you for your reply > > spin_lock_irqsave(&self->lock, flags); > > - iowrite16(data, self->membase + offset); > > + __raw_writew(data, self->membase + offset); > > spin_unlock_irqrestore(&self->lock, flags); > > Every platform, including "sh", provides ioread16() and iowrite16(). > > So changing this is not part of "fixup build error" as your commit > message states. Thank you I understand. I send v2 patch Best regards --- Kuninori Morimoto