netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Machata <me@pmachata.org>
To: Andrea Claudi <aclaudi@redhat.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org, dsahern@gmail.com
Subject: Re: [PATCH iproute2 2/2] dcb: fix memory leak
Date: Wed, 05 May 2021 10:33:34 +0200	[thread overview]
Message-ID: <87a6p960m9.fsf@nvidia.com> (raw)
In-Reply-To: <0d19dbb485632ecfbbc09e04e8151f7157e6960b.1619886883.git.aclaudi@redhat.com>


Andrea Claudi <aclaudi@redhat.com> writes:

> main() dinamically allocates dcb, but when dcb_help() is called it
> returns without freeing it.
>
> Fix this using a goto, as it is already done in the same function.
>
> Fixes: 67033d1c1c8a ("Add skeleton of a new tool, dcb")
> Signed-off-by: Andrea Claudi <aclaudi@redhat.com>

Thanks!

Reviewed-by: Petr Machata <me@pmachata.org>

  reply	other threads:[~2021-05-05  8:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-01 16:39 [PATCH iproute2 0/2] dcb: some misc fixes Andrea Claudi
2021-05-01 16:39 ` [PATCH iproute2 1/2] dcb: fix return value on dcb_cmd_app_show Andrea Claudi
2021-05-05  8:39   ` Petr Machata
2021-05-06 14:48   ` David Ahern
2021-05-01 16:39 ` [PATCH iproute2 2/2] dcb: fix memory leak Andrea Claudi
2021-05-05  8:33   ` Petr Machata [this message]
2021-05-03 14:49 ` [PATCH iproute2 0/2] dcb: some misc fixes David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6p960m9.fsf@nvidia.com \
    --to=me@pmachata.org \
    --cc=aclaudi@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).