From: Michael Ellerman <mpe@ellerman.id.au>
To: Dawei Li <set_pte_at@outlook.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "npiggin@gmail.com" <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned
Date: Thu, 07 Mar 2024 23:32:14 +1100 [thread overview]
Message-ID: <87bk7qnrxt.fsf@mail.lhotse> (raw)
In-Reply-To: <TYTP286MB356472357994D5EA49E2F5E3CA212@TYTP286MB3564.JPNP286.PROD.OUTLOOK.COM>
Dawei Li <set_pte_at@outlook.com> writes:
> Hi Christophe,
>
> On Tue, Feb 20, 2024 at 04:12:17PM +0000, Christophe Leroy wrote:
>> Hi Michael,
>>
>> ping ?
>>
>> Le 01/02/2023 à 15:36, Dawei Li a écrit :
>> > Commit fc7a6209d571 ("bus: Make remove callback return void") forces
>> > bus_type::remove be void-returned, it doesn't make much sense for any
>> > bus based driver implementing remove callbalk to return non-void to
>> > its caller.
>> >
>> > This change is for macio bus based drivers.
>> >
>> > Signed-off-by: Dawei Li <set_pte_at@outlook.com>
>>
>> This patch is Acked , any special reason for not applying it ?
>>
>> Note that it now conflicts with commit 1535d5962d79 ("wifi: remove
>> orphaned orinoco driver") but resolution is trivial, just drop the
>> changes to that file.
>
> Thanks for picking it up, hardly believe that it's been one year.
>
> Michael,
>
> I will respin V4 if it's needed.
No that's fine, I'll sort it out.
cheers
next prev parent reply other threads:[~2024-03-07 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 14:36 [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned Dawei Li
2023-02-01 21:06 ` Damien Le Moal
2023-02-03 18:27 ` Jakub Kicinski
2024-02-20 16:12 ` Christophe Leroy
2024-03-06 12:40 ` Dawei Li
2024-03-07 12:32 ` Michael Ellerman [this message]
2024-03-13 13:19 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk7qnrxt.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=alsa-devel@alsa-project.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=set_pte_at@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).