From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA14EC35249 for ; Mon, 3 Feb 2020 19:34:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE9D02080D for ; Mon, 3 Feb 2020 19:34:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iXsESQIi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbgBCTeh (ORCPT ); Mon, 3 Feb 2020 14:34:37 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:51463 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726187AbgBCTeg (ORCPT ); Mon, 3 Feb 2020 14:34:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580758475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QF3eY81eOKEDcjexNJ0roCys8uGG1rPDFto6tgn48Aw=; b=iXsESQIi1vl0YwJ22NfzQHJz+qDEGP/YOxTCbL858lnz6TjRKYk9FzEmlR7DOR8yCvtW16 qnWtkZ2dDCSUolf6BufV9IF62sgKwur56S0NL7PrSzPCrO3+8llp6+iVJ1l9nsmvgJCHOx hrUBXLWk9OKmekmt3oFKCQ0IUwvAOlI= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-cdX8eSbQOYORfg866zhVhg-1; Mon, 03 Feb 2020 14:34:31 -0500 X-MC-Unique: cdX8eSbQOYORfg866zhVhg-1 Received: by mail-lj1-f200.google.com with SMTP id j21so4332152lji.12 for ; Mon, 03 Feb 2020 11:34:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=QF3eY81eOKEDcjexNJ0roCys8uGG1rPDFto6tgn48Aw=; b=sVC39eXD8ikhHsSP6OTl/yMxe+GzxIJH6CdDpWgiuEK0FmgowJV0uxMFBxeBo9U4UI s9P6PTt/MyrV6R94tyEcKkj9/uv0Td4kGUKjre9pHaTIwV/1La91hAUVcoMVzgpaCnYr uVQz1SOdGql/FjL0Hsro7J03DNOLkQ8uLRPisYfBw6cFOFzl0Axo4JBCuFq0zLhhmbOA b3jEgzuC2DQY9R5jzrr+ZnU+2tCgGK4fAG7UBKLmlIFwH/q3Ld4G/qu1Dikz206pcDFB AkbsdFC9j9OH1K7VQpwmyLYTfQeUXe8rsMWWjH70FnhJY02kW2gtmFyn5VELND4g8X0T NHqQ== X-Gm-Message-State: APjAAAX6sESHzdnPZeyQXsF6+V14MrblYK2ODDZMi8HB+0BaAjYqikgg gsqTgRbyQesJ+nX9Wt32NQGRt3kiNslf1PfRMr4zCt9n36DyU1fRSFRBzKTQ/NyeWZmZ9/BT2/L 5rStse2ZbqwdqE58s X-Received: by 2002:a19:4f57:: with SMTP id a23mr12570103lfk.145.1580758470414; Mon, 03 Feb 2020 11:34:30 -0800 (PST) X-Google-Smtp-Source: APXvYqyfRm3ilaiQGI0UPbzdKXQHgfZ/xxEdb5Mjm5obeL7A9IdUiejM0nhLFKfOimskrPSE80TmGA== X-Received: by 2002:a19:4f57:: with SMTP id a23mr12570088lfk.145.1580758470131; Mon, 03 Feb 2020 11:34:30 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([85.204.121.218]) by smtp.gmail.com with ESMTPSA id l7sm9348914lfc.80.2020.02.03.11.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 11:34:28 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 44CF91800A2; Mon, 3 Feb 2020 20:34:28 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko Cc: Daniel Borkmann , Stephen Hemminger , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , David Miller , Jesper Dangaard Brouer , Networking , bpf Subject: Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP) In-Reply-To: References: <20190820114706.18546-1-toke@redhat.com> <87blwiqlc8.fsf@toke.dk> <43e8c177-cc9c-ca0b-1622-e30a7a1281b7@iogearbox.net> <87tva8m85t.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 03 Feb 2020 20:34:28 +0100 Message-ID: <87blqfcvnf.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Andrii Nakryiko writes: > On Wed, Aug 28, 2019 at 1:40 PM Andrii Nakryiko > wrote: >> >> On Fri, Aug 23, 2019 at 4:29 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> > >> > [ ... snip ...] >> > >> > > E.g., today's API is essentially three steps: >> > > >> > > 1. open and parse ELF: collect relos, programs, map definitions >> > > 2. load: create maps from collected defs, do program/global data/CO-= RE >> > > relocs, load and verify BPF programs >> > > 3. attach programs one by one. >> > > >> > > Between step 1 and 2 user has flexibility to create more maps, set up >> > > map-in-map, etc. Between 2 and 3 you can fill in global data, fill in >> > > tail call maps, etc. That's already pretty flexible. But we can tune >> > > and break apart those steps even further, if necessary. >> > >> > Today, steps 1 and 2 can be collapsed into a single call to >> > bpf_prog_load_xattr(). As Jesper's mail explains, for XDP we don't >> > generally want to do all the fancy rewriting stuff, we just want a >> > simple way to load a program and get reusable pinning of maps. >> >> I agree. See my response to Jesper's message. Note also my view of >> bpf_prog_load_xattr() existence. >> >> > Preferably in a way that is compatible with the iproute2 loader. >> > > > Hi Toke, > > I was wondering what's the state of converting iproute2 to use libbpf? > Is this still something you (or someone else) interested to do? Yeah, it's still on my list; planning to circle back to it once I have finished an RFC implementation for XDP multiprog loading based on the new function-replacing in the kernel. (Not that this should keep anyone else from giving the conversion a go and beating me to it :)). > Briefly re-reading the thread, I think libbpf already has almost > everything to be used by iproute2. You've added map pinning, so with > bpf_map__set_pin_path() iproute2 should be able to specify pinning > path, according to its own logic. The only thing missing that I can > see is ability to specify numa_node, which we should add both to > BTF-defined map definitions (trivial change), as well as probably > expose a method like bpf_map__set_numa_node(struct bpf_map *map, int > numa_node) for non-declarative and non-BTF legacy cases. Yes, adding this to libbpf would be good. > There was concern about supporting "extended" bpf_map_def format of > iproute2 (bpf_elf_map, actually) with extra fields. I think it's > actually easy to handle as is without any extra new APIs. > bpf_object__open() w/ .relaxed_maps =3D true option will process > compatible 5 fields of bpf_map_def (type, key/value sizes, > max_entries, and map_flags) and will set up corresponding struct > bpf_map entries (but won't create BPF maps in kernel yet). Then > iproute2 can iterate over "maps" ELF section on its own, and see which > maps need to get some more adjustments before load phase: map-in-map > set up, numa node, pinning, etc. All those adjustments can be done > (except for numa yet) through existing libbpf APIs, as far as I can > tell. Once that is taken care of, proceed to bpf_object__load() and > other standard steps. No callbacks, no extra cruft. > > Is there anything else that can block iproute2 conversion to libbpf? I haven't looked into the details since my last RFC conversion series, but from what I recall from that, and what we've been changing in libbpf since, I was basically planning to do what you explained. So while there are some details to work out, I believe it's basically straight forward, and I can't think of anything that should block it. > BTW, I have a draft patches for declarative (BTF-based) map-in-map set > up and initialization the way I described it at Plumbers last year. So > while I'm finalizing that, thought I'll resurrect iproute2 thread and > see if we can get iproute2 migration to libbpf started. Great! FWIW, as long as we have the legacy compatibility code in iproute2, I don't think it'll be a problem (or a blocker for the conversion) if BTF-defined maps can't express all the same things as the legacy maps. The missing bits will come automatically as libbpf is updated. But great to hear that you're working on this :) -Toke