From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A75CAC4360F for ; Fri, 5 Apr 2019 01:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7080E2171F for ; Fri, 5 Apr 2019 01:32:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730517AbfDEBcR (ORCPT ); Thu, 4 Apr 2019 21:32:17 -0400 Received: from mga11.intel.com ([192.55.52.93]:47539 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730440AbfDEBcR (ORCPT ); Thu, 4 Apr 2019 21:32:17 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2019 18:32:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,310,1549958400"; d="scan'208";a="333943711" Received: from cmarti8-mobl.amr.corp.intel.com (HELO ellie) ([10.254.16.36]) by fmsmga006.fm.intel.com with ESMTP; 04 Apr 2019 18:32:16 -0700 From: Vinicius Costa Gomes To: Jeff Kirsher , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, Bhagath Singh Karunakaran Subject: Re: [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus In-Reply-To: <461c66428b411644e78ad5a9a44c47442c9b6edf.camel@intel.com> References: <20190404215632.9881-1-vinicius.gomes@intel.com> <461c66428b411644e78ad5a9a44c47442c9b6edf.camel@intel.com> Date: Thu, 04 Apr 2019 18:32:16 -0700 Message-ID: <87bm1lck4f.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Jeff, Jeff Kirsher writes: > A module parameter maybe fine for our out-of-tree driver, but not for the > kernel driver. > > NACK on the basis that a new module parameter is being introduced for the > driver. This is not acceptable by Dave Miller or myself. As of now, I do > not have a alternative solution to propose unfortunately. I understand completely. This patch already served its purpose :-) > > I will discuss the issue with my fellow developers and hopefully we can > come up with a kernel interface that all drivers can use to handle this > issue. Thank you. If it helps, the only other alternative I can think of is a sysctl knob, something like: net.core.netdev_max_num_queues And the default value would be the number of cpus. Cheers, -- Vinicius