From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED70C433E9 for ; Mon, 22 Feb 2021 12:30:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EBB760C3E for ; Mon, 22 Feb 2021 12:30:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231140AbhBVM3t (ORCPT ); Mon, 22 Feb 2021 07:29:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbhBVM3d (ORCPT ); Mon, 22 Feb 2021 07:29:33 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A84D2C06174A for ; Mon, 22 Feb 2021 04:28:37 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id l12so18886761wry.2 for ; Mon, 22 Feb 2021 04:28:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=bNV1QvcJ/YkEdk4GKhB2UU/f9zwud99Ms+9a7yoCE4o=; b=lq0B6gsyj5jgBpITyBgnZnerfC/124UgbsWPXFBsyzWhfu0JxCtqocuQCADdfFbBhv 3eAeYEc8Jl9J4Fgk0Ow0g45gT2cUKXNPhh9RJ/GLC+yNDzrfykPKsAmHehZ3Ah6uIWon vMiJTByitrbFEA8MUrS6vD32hr4xSGMynlG9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=bNV1QvcJ/YkEdk4GKhB2UU/f9zwud99Ms+9a7yoCE4o=; b=BaE5mvUu8se6oyaq4T+Pz5JY0EUus7QD/rF58UQVa7urhf2Ha0ueFywZyCzgVDhY47 nEwWqEwYNzCXUn0h9TIbvrjgD1dvQBc/zYenPB/GdjhRDP+GNCFs9tczaRtvnN0I8qi3 WGZpWAwqGxpGgpGIuS6ReRMnP9P00ElFPtZ7sE0r3u1QYcdnxZZXQVkD7TxdhCDLXV5+ xAw/NBmD+/UBvfB5fO6SEQKbt9kN0+7wVecGW9vFIgMFWRnA7QjhgIbkKNo8tmcBIRgZ /vaCyN+X5Yug2GXiuprgZHq3sVdZkDr5QPM2Gm/paBNkhEfNJy2qml6Rwem5b0x1QdUS CNrg== X-Gm-Message-State: AOAM532+Um+RD2f8Fk4XkZJ2bh2FTLxBm3vGAAjEP+wXzFYPTLl2os5K A6J4gD3B/XaATNRReGIUGmXT4w== X-Google-Smtp-Source: ABdhPJxztsuiyBExH4+kF7BoprzRwWT1+c1oeqS8+jxudKRoms5A1wq8CuqYLu/HdWpUzScfO9gZPg== X-Received: by 2002:adf:f6ce:: with SMTP id y14mr21461821wrp.294.1613996916349; Mon, 22 Feb 2021 04:28:36 -0800 (PST) Received: from cloudflare.com (79.184.34.53.ipv4.supernova.orange.pl. [79.184.34.53]) by smtp.gmail.com with ESMTPSA id x18sm27553929wrs.16.2021.02.22.04.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 04:28:35 -0800 (PST) References: <20210220052924.106599-1-xiyou.wangcong@gmail.com> <20210220052924.106599-6-xiyou.wangcong@gmail.com> User-agent: mu4e 1.1.0; emacs 27.1 From: Jakub Sitnicki To: Cong Wang Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, duanxiongchun@bytedance.com, wangdongdong.6@bytedance.com, jiang.wang@bytedance.com, Cong Wang , Daniel Borkmann , Lorenz Bauer , John Fastabend Subject: Re: [Patch bpf-next v6 5/8] sock_map: rename skb_parser and skb_verdict In-reply-to: <20210220052924.106599-6-xiyou.wangcong@gmail.com> Date: Mon, 22 Feb 2021 13:28:34 +0100 Message-ID: <87czws477x.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 20, 2021 at 06:29 AM CET, Cong Wang wrote: > From: Cong Wang > > These two eBPF programs are tied to BPF_SK_SKB_STREAM_PARSER > and BPF_SK_SKB_STREAM_VERDICT, rename them to reflect the fact > they are only used for TCP. And save the name 'skb_verdict' for > general use later. > > Cc: Daniel Borkmann > Cc: Jakub Sitnicki > Reviewed-by: Lorenz Bauer > Acked-by: John Fastabend > Signed-off-by: Cong Wang > --- skb_parser also appears in: tools/testing/selftests/bpf/test_sockmap.c:int txmsg_omit_skb_parser; tools/testing/selftests/bpf/test_sockmap.c: {"txmsg_omit_skb_parser", no_argument, &txmsg_omit_skb_parser, 1}, tools/testing/selftests/bpf/test_sockmap.c: txmsg_omit_skb_parser = 0; tools/testing/selftests/bpf/test_sockmap.c: if (!txmsg_omit_skb_parser) { tools/testing/selftests/bpf/test_sockmap.c: if (!txmsg_omit_skb_parser) { tools/testing/selftests/bpf/test_sockmap.c: /* Tests that omit skb_parser */ tools/testing/selftests/bpf/test_sockmap.c: txmsg_omit_skb_parser = 1; tools/testing/selftests/bpf/test_sockmap.c: txmsg_omit_skb_parser = 0; But I understand that changing the option name could break scripts or CI setups. And even if that's not the case it can be cleanup up later. Acked-by: Jakub Sitnicki