From: Tobias Waldekranz <tobias@waldekranz.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, kuba@kernel.org, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, netdev@vger.kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol
Date: Tue, 06 Apr 2021 11:07:30 +0200 [thread overview]
Message-ID: <87eefnlr1p.fsf@waldekranz.com> (raw)
In-Reply-To: <YGCfvDhRFcfESYKx@lunn.ch>
On Sun, Mar 28, 2021 at 17:24, Andrew Lunn <andrew@lunn.ch> wrote:
> On Fri, Mar 26, 2021 at 11:56:46AM +0100, Tobias Waldekranz wrote:
>> All devices are capable of using regular DSA tags. Support for
>> Ethertyped DSA tags sort into three categories:
>>
>> 1. No support. Older chips fall into this category.
>>
>> 2. Full support. Datasheet explicitly supports configuring the CPU
>> port to receive FORWARDs with a DSA tag.
>>
>> 3. Undocumented support. Datasheet lists the configuration from
>> category 2 as "reserved for future use", but does empirically
>> behave like a category 2 device.
>
>> +static int mv88e6xxx_change_tag_protocol(struct dsa_switch *ds, int port,
>> + enum dsa_tag_protocol proto)
>> +{
>> + struct mv88e6xxx_chip *chip = ds->priv;
>> + enum dsa_tag_protocol old_protocol;
>> + int err;
>> +
>> + switch (proto) {
>> + case DSA_TAG_PROTO_EDSA:
>> + if (chip->info->tag_protocol != DSA_TAG_PROTO_EDSA)
>> + dev_warn(chip->dev, "Relying on undocumented EDSA tagging behavior\n");
>> +
>> + break;
>> + case DSA_TAG_PROTO_DSA:
>> + break;
>> + default:
>> + return -EPROTONOSUPPORT;
>> + }
>
> You are handling cases 2 and 3 here, but not 1. Which makes it a bit
> of a foot cannon for older devices.
>
> Now that we have chip->tag_protocol, maybe we should change
> chip->info->tag_protocol to mean supported protocols?
>
> BIT(0) DSA
> BIT(1) EDSA
> BIT(2) Undocumented EDSA
Since DSA is supported on all devices, perhaps we should just have:
enum mv88e6xxx_edsa_support {
MV88E6XXX_EDSA_UNSUPPORTED,
MV88E6XXX_EDSA_UNDOCUMENTED,
MV88E6XXX_EDSA_SUPPORTED,
};
?
Do we also want to default to DSA on all devices unless there is a
DT-property saying something else? Using EDSA does not really give you
anything over bare tags anymore. You have fixed the tcpdump-issue, and
the tagger drivers have been unified so there should be no risk of any
regressions there either.
next prev parent reply other threads:[~2021-04-06 9:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 10:56 [PATCH net-next 0/3] net: dsa: Allow default tag protocol to be overridden from DT Tobias Waldekranz
2021-03-26 10:56 ` [PATCH net-next 1/3] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol Tobias Waldekranz
2021-03-28 15:24 ` Andrew Lunn
2021-04-06 9:07 ` Tobias Waldekranz [this message]
2021-04-06 13:30 ` Andrew Lunn
2021-03-26 10:56 ` [PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT Tobias Waldekranz
2021-03-26 12:57 ` Vladimir Oltean
2021-03-26 13:33 ` Tobias Waldekranz
2021-03-31 13:20 ` Vladimir Oltean
2021-03-28 15:52 ` Andrew Lunn
2021-03-28 21:53 ` Vladimir Oltean
2021-03-28 22:04 ` Andrew Lunn
2021-03-29 7:15 ` Vladimir Oltean
2021-03-26 10:56 ` [PATCH net-next 3/3] dt-bindings: net: dsa: Document dsa,tag-protocol property Tobias Waldekranz
2021-03-27 18:13 ` Rob Herring
2021-04-06 9:52 ` Tobias Waldekranz
2021-04-06 13:30 ` Andrew Lunn
2021-04-07 23:34 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eefnlr1p.fsf@waldekranz.com \
--to=tobias@waldekranz.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).