From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E724C433DB for ; Wed, 17 Mar 2021 13:36:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF93F64F45 for ; Wed, 17 Mar 2021 13:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231288AbhCQNfz (ORCPT ); Wed, 17 Mar 2021 09:35:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22821 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231167AbhCQNfo (ORCPT ); Wed, 17 Mar 2021 09:35:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615988144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/RoIhEIPsIUsyZmpjJB4C/mSA9MX+NHGWNRebeNCuIA=; b=jMioJ4A4ofPVSrIhS32wm0Zq/05eQKKFwD3wYIDPqHtAK9AjoPswJGVLV76h27lG7VLNEU mxA84l9RGADcDDDoLtrP6NiFnxCXJRbFX9Czp4KmqAdjZVUs79H0CyuKnJdUqOn7I1fr0o ak1xee27nMDGLhFOHHQGsijufdwfVQ0= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-DFxSMX-2NS-BNOQC3EldxA-1; Wed, 17 Mar 2021 09:35:42 -0400 X-MC-Unique: DFxSMX-2NS-BNOQC3EldxA-1 Received: by mail-ed1-f69.google.com with SMTP id w18so16547645edu.5 for ; Wed, 17 Mar 2021 06:35:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=/RoIhEIPsIUsyZmpjJB4C/mSA9MX+NHGWNRebeNCuIA=; b=FtyQrEwNFGB32iVY35FY6NKVG0YN0JUrKHC0TqK1uocNAQEJWvQ0qv97P1n3ATxa47 o4HQDfmX9FFdoHyMYXkqst0mEZq2GMHpjZOSpdlVBBLRuQzR3H71jl4u+jFSkoH5Bwee cTuj0bW7vCJC5DKSllYzY5OHdH4Csl7Ll2zi6ZS9TjPf0TJz3lW814L2X2nF6UOygA/K qihe+caktKt8uR7ggGl+9F5HhvMGyAqj4xV41UL7c1hLRbFS21g/r/NjWNhdRXgIbsMc 942pmH1ENUJ7x637Fyenc3g9S3iLTDBOdFjMMkX9iDBa2LLQx4oWFc8lZRjUocQJvT2A 75eA== X-Gm-Message-State: AOAM531OHg+mJSIMBtoJso9xvuyzdz4WM6H4tQlABodIiyyCWwMySmpY dI5wk6D5raA5QObZ5bus8y03g0jV6D4/VbWiQ7BnfM1uAaY4Nu/0x2iLGQxCCqwmm6JqVcv+aK5 8VUEEvd/7MYYx/IK3 X-Received: by 2002:a05:6402:4301:: with SMTP id m1mr43393573edc.210.1615988141546; Wed, 17 Mar 2021 06:35:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhSou/Ggl3lyJiKJw4mWS8ik+JHdDXlS/PItqOtN6SRReDZhjCZdbefeVu8pAOm+I/A9PxHw== X-Received: by 2002:a05:6402:4301:: with SMTP id m1mr43393545edc.210.1615988141387; Wed, 17 Mar 2021 06:35:41 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id f9sm12720014eds.41.2021.03.17.06.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 06:35:40 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 35DAE181F55; Wed, 17 Mar 2021 14:35:40 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Cong Wang , Jakub Kicinski Cc: Yunsheng Lin , David Miller , Vladimir Oltean , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eric Dumazet , Wei Wang , "Cong Wang ." , Taehee Yoo , Linux Kernel Network Developers , LKML , linuxarm@openeuler.org, Marc Kleine-Budde , linux-can@vger.kernel.org, "Jason A. Donenfeld" Subject: Re: [RFC v2] net: sched: implement TCQ_F_CAN_BYPASS for lockless qdisc In-Reply-To: References: <1615603667-22568-1-git-send-email-linyunsheng@huawei.com> <1615777818-13969-1-git-send-email-linyunsheng@huawei.com> <20210315115332.1647e92b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 17 Mar 2021 14:35:40 +0100 Message-ID: <87eegddhsj.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Cong Wang writes: > On Mon, Mar 15, 2021 at 2:07 PM Jakub Kicinski wrote: >> >> I thought pfifo was supposed to be "lockless" and this change >> re-introduces a lock between producer and consumer, no? > > It has never been truly lockless, it uses two spinlocks in the ring buffer > implementation, and it introduced a q->seqlock recently, with this patch > now we have priv->lock, 4 locks in total. So our "lockless" qdisc ends > up having more locks than others. ;) I don't think we are going to a > right direction... Just a thought, have you guys considered adopting the lockless MSPC ring buffer recently introduced into Wireguard in commit: 8b5553ace83c ("wireguard: queueing: get rid of per-peer ring buffers") Jason indicated he was willing to work on generalising it into a reusable library if there was a use case for it. I haven't quite though through the details of whether this would be such a use case, but figured I'd at least mention it :) -Toke