From: ebiederm@xmission.com (Eric W. Biederman)
To: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>
Cc: Eric Dumazet <edumazet@google.com>,
adobriyan@gmail.com, David Miller <davem@davemloft.net>,
xiyou.wangcong@gmail.com, linux-netdev <netdev@vger.kernel.org>
Subject: Re: RFC: bring UP 'lo' by default after creating new netns
Date: Thu, 29 Jun 2017 20:08:58 -0500 [thread overview]
Message-ID: <87efu22set.fsf@xmission.com> (raw)
In-Reply-To: <CAF2d9jhTcVgLHs_iqw+RRS=WhMtRF0ra5SygGMymuYQUW6HP0A@mail.gmail.com> (Mahesh Bandewar's message of "Thu, 29 Jun 2017 16:57:39 -0700")
"Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com> writes:
> Creation of new network namespace is almost always followed up by
> bringing up the loopback device.
>
> ip netns add foo
> ip -netns foo link set lo up
>
> I'm not sure if there are any consequences of bringing the device UP
> at the creation of network-namespace.
Hard coded in net/core/net_namespace.c:copy_net_ns is definitely the
wrong place in the code for something like this. If this lives anywhere
it should live in driver/net/loopback.c, or possibly in
net/core/dev.c:net_dev_init.
If we want this we want to match what we do when we the primary network
namespace. Just so that there are no unneeded surprises with network
namespaces.
Eric
next prev parent reply other threads:[~2017-06-30 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 23:57 RFC: bring UP 'lo' by default after creating new netns Mahesh Bandewar (महेश बंडेवार)
2017-06-30 1:08 ` Eric W. Biederman [this message]
2017-06-30 6:26 ` Mahesh Bandewar (महेश बंडेवार)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efu22set.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).