From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Jakob Koschel <jakobkoschel@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Rapoport <rppt@kernel.org>,
Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>,
Jakob Koschel <jakobkoschel@gmail.com>
Subject: Re: [PATCH] taprio: replace usage of found with dedicated list iterator variable
Date: Wed, 30 Mar 2022 16:15:53 -0700 [thread overview]
Message-ID: <87fsmz3uc6.fsf@intel.com> (raw)
In-Reply-To: <20220324072607.63594-1-jakobkoschel@gmail.com>
Hi,
Jakob Koschel <jakobkoschel@gmail.com> writes:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---
Code wise, patch look good.
Just some commit style/meta comments:
- I think that it would make more sense that these were two separate
patches, but I haven't been following the fallout of the discussion
above to know what other folks are doing;
- Please use '[PATCH net-next]' in the subject prefix of your patch(es)
when you next propose this (net-next is closed for new submissions for
now, it should open again in a few days);
Cheers,
--
Vinicius
next prev parent reply other threads:[~2022-03-30 23:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 7:26 [PATCH] taprio: replace usage of found with dedicated list iterator variable Jakob Koschel
2022-03-30 23:15 ` Vinicius Costa Gomes [this message]
2022-03-31 9:26 ` Jakob Koschel
2022-03-31 17:58 ` Vinicius Costa Gomes
2022-04-03 11:53 ` Jakob Koschel
2022-04-04 3:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsmz3uc6.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=bjohannesmeyer@gmail.com \
--cc=c.giuffrida@vu.nl \
--cc=davem@davemloft.net \
--cc=h.j.bos@vu.nl \
--cc=jakobkoschel@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rppt@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).