From: Petr Machata <petrm@mellanox.com>
To: netdev@vger.kernel.org
Cc: Petr Machata <petrm@mellanox.com>,
Jakub Kicinski <kuba@kernel.org>, Roman Mashak <mrv@mojatatu.com>,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net,
jiri@mellanox.com, mlxsw@mellanox.com
Subject: Re: [PATCH net-next v2 3/6] net: sched: RED: Introduce an ECN tail-dropping mode
Date: Thu, 12 Mar 2020 11:17:05 +0100 [thread overview]
Message-ID: <87ftedyj1a.fsf@mellanox.com> (raw)
In-Reply-To: <20200311173356.38181-4-petrm@mellanox.com>
Petr Machata <petrm@mellanox.com> writes:
> @@ -60,6 +60,11 @@ static inline int red_use_harddrop(struct red_sched_data *q)
> return q->flags & TC_RED_HARDDROP;
> }
>
> +static inline int red_use_taildrop(struct red_sched_data *q)
Forgot to take care of the static inline :-|
> +{
> + return q->flags & TC_RED_TAILDROP;
> +}
> +
next prev parent reply other threads:[~2020-03-12 10:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 17:33 [PATCH net-next v2 0/6] RED: Introduce an ECN tail-dropping mode Petr Machata
2020-03-11 17:33 ` [PATCH net-next v2 1/6] selftests: qdiscs: Add TDC test for RED Petr Machata
2020-03-12 2:20 ` Roman Mashak
2020-03-11 17:33 ` [PATCH net-next v2 2/6] net: sched: Allow extending set of supported RED flags Petr Machata
2020-03-11 22:09 ` Jakub Kicinski
2020-03-12 0:12 ` Petr Machata
2020-03-11 17:33 ` [PATCH net-next v2 3/6] net: sched: RED: Introduce an ECN tail-dropping mode Petr Machata
2020-03-11 18:36 ` Eric Dumazet
2020-03-12 0:42 ` Petr Machata
2020-03-12 1:01 ` Eric Dumazet
2020-03-12 2:25 ` Jakub Kicinski
2020-03-12 10:16 ` Petr Machata
2020-03-12 10:17 ` Petr Machata [this message]
2020-03-11 17:33 ` [PATCH net-next v2 4/6] mlxsw: spectrum_qdisc: Offload RED " Petr Machata
2020-03-11 17:33 ` [PATCH net-next v2 5/6] selftests: qdiscs: RED: Add taildrop tests Petr Machata
2020-03-12 2:21 ` Roman Mashak
2020-03-11 17:33 ` [PATCH net-next v2 6/6] selftests: mlxsw: RED: Test RED ECN taildrop offload Petr Machata
2020-03-15 4:04 ` [PATCH net-next v2 0/6] RED: Introduce an ECN tail-dropping mode David Miller
2020-03-16 10:54 ` Petr Machata
2020-03-16 21:55 ` David Miller
2020-03-17 12:43 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftedyj1a.fsf@mellanox.com \
--to=petrm@mellanox.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=mlxsw@mellanox.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).