From: Kalle Valo <kvalo@codeaurora.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Daniel Drake <dsd@gentoo.org>,
Ulrich Kunitz <kune@deine-taler.de>,
"David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -net] zd1211rw: zd_usb: Use "%zu" to format size_t
Date: Thu, 19 Sep 2019 12:50:50 +0300 [thread overview]
Message-ID: <87h858ehs5.fsf@codeaurora.org> (raw)
In-Reply-To: <20190919091532.24951-1-geert@linux-m68k.org> (Geert Uytterhoeven's message of "Thu, 19 Sep 2019 11:15:32 +0200")
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> On 32-bit:
>
> drivers/net/wireless/zydas/zd1211rw/zd_usb.c: In function ‘check_read_regs’:
> drivers/net/wireless/zydas/zd1211rw/zd_def.h:18:25: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘size_t’ {aka ‘unsigned int’} [-Wformat=]
> dev_printk(level, dev, "%s() " fmt, __func__, ##args)
> ^~~~~~~
> drivers/net/wireless/zydas/zd1211rw/zd_def.h:22:4: note: in expansion of macro ‘dev_printk_f’
> dev_printk_f(KERN_DEBUG, dev, fmt, ## args)
> ^~~~~~~~~~~~
> drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1635:3: note: in expansion of macro ‘dev_dbg_f’
> dev_dbg_f(zd_usb_dev(usb),
> ^~~~~~~~~
> drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1636:51: note: format string is defined here
> "error: actual length %d less than expected %ld\n",
> ~~^
> %d
>
> Fixes: 84b0b66352470e64 ("zd1211rw: zd_usb: Use struct_size() helper")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
I'll queue this for v5.4.
--
Kalle Valo
next prev parent reply other threads:[~2019-09-19 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 9:15 [PATCH -net] zd1211rw: zd_usb: Use "%zu" to format size_t Geert Uytterhoeven
2019-09-19 9:50 ` Kalle Valo [this message]
2019-09-21 5:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h858ehs5.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=geert@linux-m68k.org \
--cc=gustavo@embeddedor.com \
--cc=kune@deine-taler.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).