From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Date: Wed, 13 Jun 2018 12:56:02 +0300 Message-ID: <87h8m7au31.fsf@kamboji.qca.qualcomm.com> References: <20180612113907.15043-2-niklas.cassel@linaro.org> <201806122228.8vAQXcD6%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Niklas Cassel , kbuild-all@01.org, "David S. Miller" , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: kbuild test robot Return-path: In-Reply-To: <201806122228.8vAQXcD6%fengguang.wu@intel.com> (kbuild test robot's message of "Tue, 12 Jun 2018 22:50:37 +0800") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org kbuild test robot writes: > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on ath6kl/ath-next] > [also build test WARNING on next-20180612] > [cannot apply to v4.17] > [if your patch is applied to the wrong git tree, please drop us a note > to help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Niklas-Cassel/ath10k-do-not-mix-spaces-and-tabs-in-Kconfig/20180612-194241 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/net/wireless/ath/ath10k/snoc.c:823:5: sparse: symbol >>> 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be >>> static? >>> drivers/net/wireless/ath/ath10k/snoc.c:871:6: sparse: symbol >>> 'ath10k_snoc_init_napi' was not declared. Should it be static? > > Please review and possibly fold the followup patch. There's already a patch pending to fix these: ath10k: make some functions static https://patchwork.kernel.org/patch/10440159/ -- Kalle Valo