From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17ECFA372C for ; Wed, 16 Oct 2019 10:34:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C622F2168B for ; Wed, 16 Oct 2019 10:34:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392472AbfJPKet (ORCPT ); Wed, 16 Oct 2019 06:34:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41078 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390389AbfJPKes (ORCPT ); Wed, 16 Oct 2019 06:34:48 -0400 Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2AE63680A for ; Wed, 16 Oct 2019 10:34:48 +0000 (UTC) Received: by mail-lf1-f70.google.com with SMTP id o9so4670199lfd.7 for ; Wed, 16 Oct 2019 03:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=SgWpfY5Xz4zDxp0MpMcVzJx2JBdy4PlhQXGqbdLqW1c=; b=nB1VpxMLVZ/SbyoszGWJ9E13BKBK6pKSf3psGkj1JmnPbNWDJXF4oeuLZ8rnFeKF3s icNP8JcTA1N8Gu+yvYvAKPT1fZXr3GoPuuaOdADR+jWsJrd0xxhlpQJ5zhnzWuXdDNSP /MorkPG9msAwYEkkknt7yO7grxhHOeT1Q7mHCFu2augKPJhnq+SS+0YiUnoziyW1Vw74 PSeJgXKjCU82820GNDEepIeJ2GR3aMTVKi2iXF6XNJpsRP1nhNQCSH3ry2/aVE05WL5+ ZOg7WEkWw0lYzaoPT8p7kPQaX1tv68og1lzDc8/qBxoWzprM6J6Ozqbd7HVn5bprAmHI YzxQ== X-Gm-Message-State: APjAAAVJoXiJtIsUxXtA2xIXYag9/wNAFxoLcJcJe7PtynfKdpggLCSD lAtv7BayQkKyTXOXdSbTvkzUuVEzKYwqcta8dPdq8O1DYgoejnXLdC50J7AZP9jZmhsABam7i4S QeU8gSlrJIwtH9+OH X-Received: by 2002:a2e:8908:: with SMTP id d8mr25165959lji.197.1571222087131; Wed, 16 Oct 2019 03:34:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqx4XYHDPAfrBOTyCsdEH7wCjKz6XyRUDaC+zt/SS3g8SNH7/oIXHGkUSk//39pfT1paBIYsMQ== X-Received: by 2002:a2e:8908:: with SMTP id d8mr25165952lji.197.1571222086968; Wed, 16 Oct 2019 03:34:46 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id v1sm6234517lfq.89.2019.10.16.03.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 03:34:45 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 174401800F4; Wed, 16 Oct 2019 12:34:45 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Alexei Starovoitov , Tetsuo Handa , Jesper Dangaard Brouer Cc: Alexei Starovoitov , Daniel Borkmann , syzbot , ddstreet@ieee.org, Dmitry Vyukov , LKML , Network Development , syzkaller-bugs , bpf Subject: Re: unregister_netdevice: waiting for DEV to become free (2) In-Reply-To: References: <00000000000056268e05737dcb95@google.com> <0000000000007d22100573d66078@google.com> <063a57ba-7723-6513-043e-ee99c5797271@I-love.SAKURA.ne.jp> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 16 Oct 2019 12:34:45 +0200 Message-ID: <87imopgere.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Alexei Starovoitov writes: > On Fri, Oct 11, 2019 at 3:15 AM Tetsuo Handa > wrote: >> >> Hello. >> >> I noticed that syzbot is reporting that refcount incremented by bpf(BPF_MAP_UPDATE_ELEM) >> syscall is not decremented when unregister_netdevice() is called. Is this a BPF bug? > > Jesper, Toke, > please take a look. Yeah, that unregister notification handler definitely looks broken for hashmaps; I'll send a patch :) -Toke