From: Tobias Waldekranz <tobias@waldekranz.com>
To: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, vivien.didelot@gmail.com,
f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Provide dummy implementations for trunk setters
Date: Fri, 15 Jan 2021 21:12:07 +0100 [thread overview]
Message-ID: <87lfcuklig.fsf@waldekranz.com> (raw)
In-Reply-To: <YAGrRJYRpWg/4Yl5@lunn.ch>
On Fri, Jan 15, 2021 at 15:48, Andrew Lunn <andrew@lunn.ch> wrote:
> On Fri, Jan 15, 2021 at 04:36:49PM +0200, Vladimir Oltean wrote:
>> On Fri, Jan 15, 2021 at 03:30:30PM +0100, Andrew Lunn wrote:
>> > On Fri, Jan 15, 2021 at 11:58:33AM +0100, Tobias Waldekranz wrote:
>> > > Support for Global 2 registers is build-time optional.
>> >
>> > I was never particularly happy about that. Maybe we should revisit
>> > what features we loose when global 2 is dropped, and see if it still
>> > makes sense to have it as optional?
>>
>> Marvell switch newbie here, what do you mean "global 2 is dropped"?
>
> I was not aware detect() actually enforced it when needed. It used to
> be, you could leave it out, and you would just get reduced
> functionality for devices which had global2, but the code was not
> compiled in.
>
> At the beginning of the life of this driver, i guess it was maybe
> 25%/75% without/with global2, so it might of made sense to reduce the
> binary size. But today the driver is much bigger with lots of other
> things which those early chips don't have, SERDES for example. And
> that ratio has dramatically reduced, there are very few devices
> without those registers. This is why i think we can make our lives
> easier and make global2 always compiled in.
Hear, hear!
I took a quick look at the (stripped) object sizes (ppc32):
# du -ab
6116 ./global1_vtu.o
5904 ./devlink.o
11500 ./port.o
9640 ./global2.o
3016 ./phy.o
5368 ./global1.o
51784 ./chip.o
9892 ./serdes.o
5140 ./global1_atu.o
1916 ./global2_avb.o
2248 ./global2_scratch.o
948 ./port_hidden.o
1828 ./smi.o
119396 .
So, roughly, you save 10%/13k. That hardly justifies the complexity IMO.
Andrew, do you want to do this? If not, I can look into it.
next prev parent reply other threads:[~2021-01-15 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 10:58 [PATCH net-next 0/2] net: dsa: mv88e6xxx: LAG fixes Tobias Waldekranz
2021-01-15 10:58 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: Provide dummy implementations for trunk setters Tobias Waldekranz
2021-01-15 11:10 ` Vladimir Oltean
2021-01-15 14:30 ` Andrew Lunn
2021-01-15 14:36 ` Vladimir Oltean
2021-01-15 14:48 ` Andrew Lunn
2021-01-15 14:53 ` Vladimir Oltean
2021-01-15 20:12 ` Tobias Waldekranz [this message]
2021-01-18 17:54 ` Andrew Lunn
2021-01-15 10:58 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: Only allow LAG offload on supported hardware Tobias Waldekranz
2021-01-15 11:15 ` Vladimir Oltean
2021-01-15 11:29 ` Vladimir Oltean
2021-01-15 14:39 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfcuklig.fsf@waldekranz.com \
--to=tobias@waldekranz.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).