From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: "Daniel T. Lee" <danieltimlee@gmail.com>,
Jesper Dangaard Brouer <brouer@redhat.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [v4 1/4] samples: pktgen: make variable consistent with option
Date: Fri, 04 Oct 2019 15:48:49 +0200 [thread overview]
Message-ID: <87lfu0oc3i.fsf@toke.dk> (raw)
In-Reply-To: <CAEKGpzhmkDBGV5BmwwYgb0ng+Eyyzp2CFoGeZ65aEgR=CxWnMg@mail.gmail.com>
"Daniel T. Lee" <danieltimlee@gmail.com> writes:
> On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer <brouer@redhat.com>
> wrote:
>
>>
>> On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee" <danieltimlee@gmail.com>
>> wrote:
>>
>> > [...]
>>
>>
> Thanks for the review!
>
>
>> A general comment, you forgot a cover letter for your patchset.
>>
>>
> At first, I thought the size of the patchset (the feature to enhance) was
> small so
> I didn't include it with intent, but now it gets bigger and it seems
> necessary for cover letter.
>
> When the next version is needed, I'll include it.
>
>
>> And also forgot the "PATCH" part of subj. but patchwork still found it:
>> https://patchwork.ozlabs.org/project/netdev/list/?series=134102&state=2a
>>
>>
> I'm not sure I'm following.
> Are you saying that the word "PATCH" should be included in prefix?
> $ git format-patch --subject-prefix="PATCH,v5"
> like this?
$ git format-patch --subject-prefix="PATCH bpf-next" -v5
would be the right incantation for this :)
-Toke
next prev parent reply other threads:[~2019-10-04 13:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 1:32 [v4 1/4] samples: pktgen: make variable consistent with option Daniel T. Lee
2019-10-04 1:32 ` [v4 2/4] samples: pktgen: fix proc_cmd command result check logic Daniel T. Lee
2019-10-04 13:24 ` Jesper Dangaard Brouer
2019-10-04 15:11 ` Daniel T. Lee
2019-10-04 1:33 ` [v4 3/4] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing Daniel T. Lee
2019-10-04 1:33 ` [v4 4/4] samples: pktgen: allow to specify destination IP range (CIDR) Daniel T. Lee
2019-10-04 12:51 ` [v4 1/4] samples: pktgen: make variable consistent with option Jesper Dangaard Brouer
2019-10-04 13:28 ` Daniel T. Lee
2019-10-04 13:41 ` Jesper Dangaard Brouer
2019-10-04 13:46 ` Daniel T. Lee
[not found] ` <CAEKGpzhmkDBGV5BmwwYgb0ng+Eyyzp2CFoGeZ65aEgR=CxWnMg@mail.gmail.com>
2019-10-04 13:48 ` Toke Høiland-Jørgensen [this message]
2019-10-04 12:54 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfu0oc3i.fsf@toke.dk \
--to=toke@redhat.com \
--cc=brouer@redhat.com \
--cc=danieltimlee@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).