From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: David Ahern <dsahern@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, Juliusz Chroboczek <jch@irif.fr>
Subject: Re: [PATCH net] icmp: don't send out ICMP messages with a source address of 0.0.0.0
Date: Thu, 17 Jun 2021 17:39:26 +0200 [thread overview]
Message-ID: <87o8c4ec0h.fsf@toke.dk> (raw)
In-Reply-To: <be61a82e-1a21-d302-dcdc-8409130e8fb7@gmail.com>
David Ahern <dsahern@gmail.com> writes:
> On 6/17/21 9:06 AM, David Ahern wrote:
>>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> This should be the one that allows IPv6 nexthops with IPv4 routes.
>>
>> Fixes: d15662682db2 ("ipv4: Allow ipv6 gateway with ipv4 routes")
>>
>
> on further thought, this is the receiving / transit path and not the
> sending node, so my change to allow v6 gw with v4 routes is not relevant.
Right, so you're OK with keeping the patch as-is, then? I can send a
test-case as a follow-up...
-Toke
prev parent reply other threads:[~2021-06-17 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 11:07 [PATCH net] icmp: don't send out ICMP messages with a source address of 0.0.0.0 Toke Høiland-Jørgensen
2021-06-17 15:06 ` David Ahern
2021-06-17 15:18 ` David Ahern
2021-06-17 15:39 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8c4ec0h.fsf@toke.dk \
--to=toke@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=jch@irif.fr \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).