From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C053BC433DF for ; Sat, 30 May 2020 08:55:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 868002074A for ; Sat, 30 May 2020 08:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="rNCDQ4dP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728086AbgE3Iz6 (ORCPT ); Sat, 30 May 2020 04:55:58 -0400 Received: from mail-eopbgr50061.outbound.protection.outlook.com ([40.107.5.61]:4686 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725554AbgE3Iz6 (ORCPT ); Sat, 30 May 2020 04:55:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SpmcCryWrZqiEWrMdzSq9owEg3U8A1nSNIfH6WK40vraai+jxqCDMA4lz6+u+qlgxCtE8g0n1TEhy+Jnk8hlL9c9fsG8f5nbqoX0aPe5SL0I+714W9DIHEqrcM94IC/dD8eUmsSZ56wZE3wUjuz+Cy3I85v1ZNL2A3mfM3zExlTUQL2g/muIQf6vV/7x5vlRK9CK6daPGncKMuWPuieekuSnQXrRdjdd63oUICgrZZlvT8VyO2MjETGbkb48vYJMXsKeySWvLNwizGdOz/glNxbb1xxCQd1MQyBbkxtRk03y2sHKiC68FMbgPpnzlSfuGnO+PDogBT0EtXmOHko9Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Zd3ihHkFtf/R8HHfrXHh/3b/VCtxQWSl0mZnJA9YzQ=; b=jV1gLHk4l2eVYvusvd5gW3Jtut1tmyL3DHqU+9/aUTwToggxyGU1hf/v2hifO3FRalRNHuEQrHkw0LBuqVkkpdD+b/XyDc0EJF2bwTilVII43ALgOopWENI8JWineHcf5VUBWdwXQmHOmOFQ+E/bpZ9YxyoVrsxhgmUL8d+e3ajiMko+UG60OzMiag0Agj0x8BYMj3voSKiIrQSxd0UG/mh3SptZPY+2OZSAoHmy2ifp1QyohoQfU3O7yeFBioFNOdz5HEuTfvquQ68W7VdaTJ3JKcD38IBqt7eeUnW8Bz8qEtiPxYde8zMBmm8jM98Ax2OpT7N+UiaCEnUSOy+ECw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Zd3ihHkFtf/R8HHfrXHh/3b/VCtxQWSl0mZnJA9YzQ=; b=rNCDQ4dP7S0s0fW20PwgWqVNYC0qJqMb/SEf3UsVVMNmiDqmyvydB8LdgcVSuQZjvyXDe7B+PFOHBp4E9+6SxfV4ZytY/w3NZinMEcH1ywDEyCO40LHizefsEwLfv19zpH33QGk0aTX4TSWwbNmm1hPKlewS9TakGdWOWU4eTD8= Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; Received: from HE1PR05MB4746.eurprd05.prod.outlook.com (2603:10a6:7:a3::22) by HE1PR05MB3482.eurprd05.prod.outlook.com (2603:10a6:7:2d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Sat, 30 May 2020 08:55:53 +0000 Received: from HE1PR05MB4746.eurprd05.prod.outlook.com ([fe80::9de2:ec4b:e521:eece]) by HE1PR05MB4746.eurprd05.prod.outlook.com ([fe80::9de2:ec4b:e521:eece%5]) with mapi id 15.20.3045.022; Sat, 30 May 2020 08:55:53 +0000 References: <877dwxvgzk.fsf@mellanox.com> <87wo4wtmnx.fsf@mellanox.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Petr Machata To: Cong Wang Cc: Linux Kernel Network Developers , Jakub Kicinski , Eric Dumazet , Jamal Hadi Salim , Jiri Pirko , Ido Schimmel Subject: Re: [RFC PATCH net-next 0/3] TC: Introduce qevents In-reply-to: Date: Sat, 30 May 2020 10:55:50 +0200 Message-ID: <87o8q5u7hl.fsf@mellanox.com> Content-Type: text/plain X-ClientProxiedBy: AM3PR07CA0135.eurprd07.prod.outlook.com (2603:10a6:207:8::21) To HE1PR05MB4746.eurprd05.prod.outlook.com (2603:10a6:7:a3::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from yaviefel (89.176.246.183) by AM3PR07CA0135.eurprd07.prod.outlook.com (2603:10a6:207:8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.7 via Frontend Transport; Sat, 30 May 2020 08:55:52 +0000 X-Originating-IP: [89.176.246.183] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6422ada5-b7a0-43ba-b6bf-08d80477422a X-MS-TrafficTypeDiagnostic: HE1PR05MB3482: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 041963B986 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4x6Hl4xkDzr7cBlZJwxsyAc8fdp+zCs7evFDpuTK9tOV386zLEPis1ro3qFAo9foKKuFkFSc++5cbww2lVd4FNxOPIBf8ja6+6JAzsdfr5VfY5GtR7adqVOphzI+FLo7FLMqSKEDRRS3BLwfRE6NlP+jO6xau6W/ESHbBESj650P4NtZOn37LXwf3E2sPIZ0gKxniJsdjvQj2O9G/59WjUHFAz+NF8Curehf3VHpUIvdfykCRUD+Novf8ExvoxXfsSXRisK1I/v2twpgyaDfxWhiXAhH0ZvJYMrYkZ4rZ7eFowudQry6ppG+mAT6lx0A/o0ZR61yN6jxga3p8KUweA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR05MB4746.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(86362001)(956004)(6916009)(66476007)(186003)(16526019)(478600001)(26005)(2616005)(6496006)(5660300002)(316002)(53546011)(2906002)(52116002)(54906003)(66556008)(36756003)(107886003)(83380400001)(66946007)(8676002)(6486002)(4326008)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 8cbOB6v8ymDF00fNOTfgY4C+FbWLTkPpE7FsZ2fUjI6eT/rWidilOmHSeb/nTrOFE7GBjfFaHw9pAdF1nAP0Ab6BrwT/3BQCA7N9qcMrGn5ajh7u+qYNKCpnFX+XFCB3g8vA55oPoaVixG/d2qFyJaVO7ZZORbM4UzPPobvm5bNnm7IRUmIySaB9Iz8P8G/vyPecNmWnwwwfnhukxIjmNG7yUZ4Sq+b1o/nXZfCrfs2cbh6betnKKmuci1wY+86NMffBQ4MP2JxVwLrTnfpxY5msFGdYMiXB0ouP3du6MuhAkxWOiqPCHHbfaBNcTAtaX70wIcfJ9EgL22yRudOSuBWv6f4Ow7J2TWLBiYX3m8m3iH2TnKTN51y/ZYIukV3jMP0WZQ/CP79T6pifGimCA5LUYzz52aTICUOIeEwDqeaq/DSXjCDfcnteKwVi75E2PHquKpYNu/xqxL3MsdSeXZXmKw19RNnZuxpUdI7FoUxVcByPnpW8aQm/p7y0ufGM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6422ada5-b7a0-43ba-b6bf-08d80477422a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2020 08:55:53.3178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jq5QgmKWczVZBhJRGWIyIeS3sG0KiYzJ5L4TzEzd00W+/jNr7bpx30uWVF44BLpcOsguO0WwNhtYfQKFGlX+yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB3482 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Cong Wang writes: > On Thu, May 28, 2020 at 2:48 AM Petr Machata wrote: >> So you propose to have further division within the block? To have sort >> of namespaces within blocks or chains, where depending on the context, >> only filters in the corresponding namespace are executed? > > What I suggest is to let filters (or chain or block) decide where > they belong to, because I think that fit naturally. So filters would have this attribute that marks them for execution in the qevent context? Does "goto chain" keep this position? I.e. are the executed filters from the "position" context or not? If they keep the position, then this new system can be equivalently modeled as simply a block binding point. If "goto chain" loses the position, that is just a block binding point and a chain to start on, instead of the default zero. So introducing the position does not seem to allow us to model anything that could not be modeled before. But it is a more complicated system. > What you suggest is to let qdisc's decide where they put filters, > which looks odd to me. Ultimately the qdisc decides what qevents to expose. Qevents are closely tied to the inner workings of a qdisc algorithm, they can't be probed as modules the way qdiscs, filters and actions can. If a user wishes to make use of them, they will have to let qdiscs "dictate" where to put the filters one way or another.